-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] Add traces for event stop session in Node #15348
Conversation
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit f58fbd9)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one little thing, but looks promising.
It might be also a good idea to let the EventBus create spans for each event?
But this might get a little more complex, than i am currently thinking :D
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
a9951fe
to
f58fbd9
Compare
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Adding more trace info on the event session removal.
Both removing session on demand (e.g
driver.quit()
) and stopping the timed-out session call methodstopTimedOutSession()
in LocalNode.Based on the condition of
notification.wasEvicted() && notification.getCause() == RemovalCause.EXPIRED
to determine session timed out and add trace info with statusABORTED
. Otherwise, trace info will clarify that the session is stopped on demand.Trace data of session timed out.
Trace data of session is stopped explicitly.
Types of changes
Checklist
PR Type
Enhancement
Description
Added detailed tracing for session stop events in
LocalNode
.Differentiated between timed-out and on-demand session stops.
Integrated tracing attributes and events for node draining process.
Improved logging and error handling during session stop operations.
Changes walkthrough 📝
LocalNode.java
Enhanced tracing and error handling in LocalNode
java/src/org/openqa/selenium/grid/node/local/LocalNode.java