Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AUTHORS #15316

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Feb 20, 2025

User description

Add entry to .mailmap for Corey Goldberg.

Motivation and Context

This PR adds an entry to .mailmap with my name and multiple email addresses.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist


PR Type

Bug fix


Description

  • Added entry to .mailmap with new name and email addresses.

  • Ensures the email matches the GitHub account alias.


Changes walkthrough 📝

Relevant files
Bug fix
AUTHORS
Update Corey Goldberg's email address                                       

AUTHORS

  • Updated Corey Goldberg's email address.
  • Added new GitHub alias.
  • +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Sorry, something went wrong.

    Update email for Corey Goldberg in AUTHORS file.
    @CLAassistant
    Copy link

    CLAassistant commented Feb 20, 2025

    CLA assistant check
    All committers have signed the CLA.

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Feb 20, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @VietND96
    Copy link
    Member

    Later, once a new release preparation is executed, your old email will be added back. So, I think you can add new line with a new email.
    In local, you can check by execute ./go "authors"

    I had replaced my old email a with new one in the AUTHORS file.
    
    But according to this, I need to add the old one back so the file contains both?
    
    SeleniumHQ#15316 (comment)
    @cgoldberg
    Copy link
    Contributor Author

    I think you can add new line with a new email.

    @VietND96

    OK, I updated my branch so it contains 2 entries... my old email and new email alias.

    Kind of weird, but I guess it makes sense since I have merged commits tied to my old email address.

    Let me know if you need anything else to get this merged.

    Thanks!

    @titusfortner
    Copy link
    Member

    authors file is automatically generated. Use .mailmap file to manage multiple emails - https://git-scm.com/docs/gitmailmap

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Reverting edits to AUTHORS since this file is apparently auto-generated.
    Add a new entry to .mailmap with my name and multiple email addresses.
    @AutomatedTester
    Copy link
    Member

    Glad to have you back in the community, it's been a while!

    @AutomatedTester AutomatedTester merged commit 583d008 into SeleniumHQ:trunk Feb 21, 2025
    7 of 9 checks passed
    @cgoldberg cgoldberg deleted the update-authors-email branch February 21, 2025 22:31
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    5 participants