-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AUTHORS #15316
Update AUTHORS #15316
Conversation
Update email for Corey Goldberg in AUTHORS file.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Later, once a new release preparation is executed, your old email will be added back. So, I think you can add new line with a new email. |
I had replaced my old email a with new one in the AUTHORS file. But according to this, I need to add the old one back so the file contains both? SeleniumHQ#15316 (comment)
OK, I updated my branch so it contains 2 entries... my old email and new email alias. Kind of weird, but I guess it makes sense since I have merged commits tied to my old email address. Let me know if you need anything else to get this merged. Thanks! |
authors file is automatically generated. Use .mailmap file to manage multiple emails - https://git-scm.com/docs/gitmailmap |
Reverting edits to AUTHORS since this file is apparently auto-generated.
Add a new entry to .mailmap with my name and multiple email addresses.
Glad to have you back in the community, it's been a while! |
User description
Add entry to .mailmap for Corey Goldberg.
Motivation and Context
This PR adds an entry to .mailmap with my name and multiple email addresses.
Types of changes
Checklist
PR Type
Bug fix
Description
Added entry to .mailmap with new name and email addresses.
Ensures the email matches the GitHub account alias.
Changes walkthrough 📝
AUTHORS
Update Corey Goldberg's email address
AUTHORS