[py] Moved Rust binary settings to pyproject.toml
from setup.py
#14837
+4
−43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved Rust binary settings to
pyproject.toml
fromsetup.py
thus completely eliminating the need ofsetup.py
Motivation and Context
setup.py
as all the settings are moved topyproject.toml
bazel build //py:selenium-wheel
which is successful.selenium
from.whl
file, the installation was successful.selenium-manager
is present inselenium.webdriver.common
folder (in /linux, /macos, /windows)--no-binary
option as well.Types of changes
Checklist
PR Type
enhancement
Description
setup.py
file, migrating its configurations topyproject.toml
.pyproject.toml
to include Rust binary settings forselenium-manager
.setup.py
from the source files.Changes walkthrough 📝
setup.py
Remove setup.py and migrate configurations
py/setup.py
setup.py
file entirely.setup.py
by moving configurations.pyproject.toml
Add Rust binary settings to pyproject.toml
py/pyproject.toml
selenium-manager
.BUILD.bazel
Update Bazel build configuration for setup.py removal
py/BUILD.bazel
setup.py
from the list of source files.