Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] Fix linting #13753

Merged
merged 2 commits into from
Apr 1, 2024
Merged

[js] Fix linting #13753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd61808
[js] Fix linting
pujagani Mar 28, 2024
eae683e
Revert changes to bazel file
pujagani Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions javascript/node/selenium-webdriver/test/bidi/script_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,6 @@ suite(
})

it('can access preload script properties', async function () {
const id = await driver.getWindowHandle()
const manager = await ScriptManager([], driver)

await manager.addPreloadScript('() => { window.preloadScriptFunction = () => window.baz = 42; }')
Expand All @@ -602,7 +601,6 @@ suite(
})

it('can add preload script to sandbox', async function () {
const id = await driver.getWindowHandle()
const manager = await ScriptManager([], driver)

await manager.addPreloadScript('() => { window.foo = 1; }')
Expand Down Expand Up @@ -638,7 +636,6 @@ suite(
})

it('can remove properties set by preload script', async function () {
const id = await driver.getWindowHandle()
const manager = await ScriptManager([], driver)

await manager.addPreloadScript('() => { window.foo = 42; }')
Expand All @@ -657,7 +654,6 @@ suite(
})

it('can remove preload script', async function () {
const id = await driver.getWindowHandle()
const manager = await ScriptManager([], driver)

let script = await manager.addPreloadScript("() => { window.foo='bar'; }")
Expand All @@ -682,7 +678,6 @@ suite(
})

it('cannot remove same preload script twice', async function () {
const id = await driver.getWindowHandle()
const manager = await ScriptManager([], driver)

let script = await manager.addPreloadScript("() => { window.foo='bar'; }")
Expand All @@ -695,7 +690,6 @@ suite(
})

it('can remove one of preload script', async function () {
const id = await driver.getWindowHandle()
const manager = await ScriptManager([], driver)

let script_1 = await manager.addPreloadScript("() => { window.bar='foo'; }")
Expand Down
2 changes: 1 addition & 1 deletion javascript/node/selenium-webdriver/test/bidi/setFiles_command_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const { Pages, suite } = require('../../lib/test')
const { Browser, By } = require('../..')
const Input = require('../../bidi/input')
const io = require('../../io')
const fs = require('node:fs')
const { ReferenceValue, RemoteReferenceType } = require('../../bidi/protocolValue')
const fs = require('fs')

suite(
function (env) {
Expand Down
2 changes: 1 addition & 1 deletion javascript/node/selenium-webdriver/test/bidi/storage_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
const assert = require('assert')
require('../../lib/test/fileserver')
const firefox = require('../../firefox')
const { ignore, suite } = require('../../lib/test')
const { suite } = require('../../lib/test')
const { Browser } = require('../..')
const Storage = require('../../bidi/storage')
const fileserver = require('../../lib/test/fileserver')
Expand Down
5 changes: 3 additions & 2 deletions javascript/node/selenium-webdriver/test/driver_factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@
const fs = require('fs')
const os = require('os')
const path = require('path')
const { Builder, Browser } = require('../index')
const { Browser } = require('../index')
const { Environment } = require('../testing')
const chrome = require('../chrome')
const firefox = require('../firefox')
// eslint-disable-next-line node/no-missing-require
const { runfiles } = require('@bazel/runfiles')

function GetBrowserForTests() {
Expand Down Expand Up @@ -90,7 +91,7 @@ function GetBrowserForTests() {
break

case 'safari':
builder.forBrowser(webdriver.Browser.SAFARI)
builder.forBrowser(Browser.SAFARI)
break

default:
Expand Down