-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] support wheel also to build sync actions #13619
base: trunk
Are you sure you want to change the base?
[py] support wheel also to build sync actions #13619
Conversation
Can you add a test that shows what you're after and that passes after this change? Looking at the code I don't think it is doing what you're after but would like to see a test in case I am missing something |
I modified the existing test case to fail on the trunk branch. On the trunk: pointerDown and scroll actions are performed at the same time. [
{ type: "pointer", .., actions: [{ pointerDown }, { pointerUp }, { pause 0 }, { pause 0 }, { pause 0 } ...],
{ type: "key", ......, actions: [{ pause 0 }, { pause 0 }, { keyDown f }, { keyUp f }, { keyDown o } ...],
{ type: "wheel", ...., actions: [{ scroll }]
] Fixed: [
{ type: "pointer", .., actions: [{ pointerDown }, { pointerUp }, { pause 0 }, { pause 0 }, { pause 0 }, { pause 0 } ...],
{ type: "key", ......, actions: [{ pause 0 }, { pause 0 }, { pause 0 }, { keyDown f }, { keyUp f }, { keyDown o } ...],
{ type: "wheel", ...., actions: [{ pause 0 }, { pause 0 }, { scroll }, { pause 0 }, { pause 0 }, { pause 0 } ...]
] |
5127331
to
f9fef5c
Compare
7039c04
to
007f845
Compare
007f845
to
236cbb1
Compare
@AutomatedTester |
236cbb1
to
3ab9f78
Compare
3ab9f78
to
d92dc34
Compare
Description
Make ActionChains.scroll_* functions fill pause to key, pointer actions queue each for building sync actions.
And make the other functions fill pause to scroll actions queue also.
Motivation and Context
Problem:
When run the code below, pause actions are carried out differently than intended.
Built actions:
Should be(simplified):
Types of changes
Checklist