Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EdgeDB] Create Product.CompletionDescription schema #3089

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

atGit2021
Copy link
Contributor

@atGit2021 atGit2021 commented Feb 23, 2024

@atGit2021 atGit2021 self-assigned this Feb 23, 2024
dbschema/pagination-input.esdl Outdated Show resolved Hide resolved
@bryanjnelson bryanjnelson changed the title Create pagination and product completion description schema [EdgeDB] Create Product.CompletionDescription schema Feb 26, 2024
@bryanjnelson bryanjnelson marked this pull request as ready for review February 28, 2024 03:09
Copy link
Contributor

@bryanjnelson bryanjnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarsonF - I'm unsure how/if the possible matches provided by the query search play in here?

dbschema/product.esdl Outdated Show resolved Hide resolved
dbschema/product.esdl Outdated Show resolved Hide resolved
dbschema/product.esdl Show resolved Hide resolved
dbschema/product.esdl Outdated Show resolved Hide resolved
@CarsonF
Copy link
Member

CarsonF commented Feb 28, 2024

@CarsonF - I'm unsure how/if the possible matches provided by the query search play in here?

Yeah this uses full text search. We'll need FTS indexes here eventually. Something like this

index fts::index on (
fts::with_options(
.name,
language := fts::Language.eng,
)
);

The EdgeQL query will be something like

select fts::search(Product::CompletionDescription, '<query>', language := 'eng');

@atGit2021 atGit2021 force-pushed the 0973-EdgeDB-Product-Completion-Description branch from 49a6688 to 0f357ad Compare March 5, 2024 01:33
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still wonder if we actually need this object or product holds enough info to use.
Still need the FTS index either way. We can revisit with the queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants