Agl/add is language of consultiung boolean #2983

adam-soltech · 2023-12-06T20:27:07Z

┆Issue is synchronized with this Monday item by Unito

github-actions · 2023-12-06T20:31:49Z

🗞 GraphQL Summary

View schema changes

@@ -624,8 +624,11 @@
   displayNamePronunciation: String
   ethnologue: CreateEthnologueLanguage = {}
   hasExternalFirstScripture: Boolean = false
   isDialect: Boolean = false
+  isLanguageOfConsulting: Boolean = false
+  isLanguageOfReporting: Boolean
+  isLanguageOfWiderCommunication: Boolean
   isSignLanguage: Boolean = false
   leastOfThese: Boolean = false
   leastOfTheseReason: String
   name: String!
@@ -751,8 +754,9 @@
   countries: [ID!] = []
   fieldRegions: [ID!] = []
   financialReportingTypes: [FinancialReportingType!] = []
   globalInnovationsClient: Boolean
+  languageOfReportingId: ID
   languageOfWiderCommunicationId: ID
   languagesOfConsulting: [ID!] = []
   organizationId: ID!
   pmcEntityCode: String
@@ -2297,8 +2301,11 @@
   id: ID!
 
   """Whether this language is a dialect."""
   isDialect: SecuredBoolean!
+  isLanguageOfConsulting: SecuredBoolean!
+  isLanguageOfReporting: SecuredBoolean!
+  isLanguageOfWiderCommunication: SecuredBoolean!
   isSignLanguage: SecuredBoolean!
 
   """Whether this language has a Least Of These grant."""
   leastOfThese: SecuredBoolean!
@@ -2443,8 +2450,11 @@
 }
 
 input LanguageFilters {
   isDialect: Boolean
+  isLanguageOfConsulting: Boolean
+  isLanguageOfReporting: Boolean
+  isLanguageOfWiderCommunication: Boolean
   isSignLanguage: Boolean
 
   """Is a Least Of These partnership"""
   leastOfThese: Boolean
@@ -3219,8 +3229,9 @@
   globalInnovationsClient: SecuredBoolean!
 
   """The object's ID"""
   id: ID!
+  languageOfReporting: SecuredLanguageNullable!
   languageOfWiderCommunication: SecuredLanguageNullable!
 
   """Languages of the partner's affiliated translation projects"""
   languages(input: LanguageListInput = {count: 25, filter: {}, order: ASC, page: 1, sort: "name"}): SecuredLanguageList!
@@ -6726,8 +6737,11 @@
   ethnologue: UpdateEthnologueLanguage
   hasExternalFirstScripture: Boolean
   id: ID!
   isDialect: Boolean = false
+  isLanguageOfConsulting: Boolean
+  isLanguageOfReporting: Boolean
+  isLanguageOfWiderCommunication: Boolean
   isSignLanguage: Boolean
   leastOfThese: Boolean = false
   leastOfTheseReason: String
   name: String
@@ -6859,8 +6873,9 @@
   fieldRegions: [ID!]
   financialReportingTypes: [FinancialReportingType!]
   globalInnovationsClient: Boolean
   id: ID!
+  languageOfReportingId: ID
   languageOfWiderCommunicationId: ID
   languagesOfConsulting: [ID!]
   pmcEntityCode: String
   pointOfContactId: ID

⚠️ Dangerous Changes

An optional field isLanguageOfConsulting on input type CreateLanguage was added.
An optional field isLanguageOfReporting on input type CreateLanguage was added.
An optional field isLanguageOfWiderCommunication on input type CreateLanguage was added.
An optional field languageOfReportingId on input type CreatePartner was added.
An optional field isLanguageOfConsulting on input type LanguageFilters was added.
An optional field isLanguageOfReporting on input type LanguageFilters was added.
An optional field isLanguageOfWiderCommunication on input type LanguageFilters was added.
An optional field isLanguageOfConsulting on input type UpdateLanguage was added.
An optional field isLanguageOfReporting on input type UpdateLanguage was added.
An optional field isLanguageOfWiderCommunication on input type UpdateLanguage was added.
An optional field languageOfReportingId on input type UpdatePartner was added.

bryanjnelson

Thanks @adam-soltech!

bryanjnelson · 2023-12-11T19:03:25Z

dbschema/migrations/00033.edgeql

You wouldn't have known this, but we're not actually checking in EdgeDB Migrations at this point. Carson is handling this himself, and grouping them together as makes sense. Eventually that will change after we're fully migrated, but for now don't worry about doing the migration.

Without the migration the e2e tests failed

Ah yes. Then for now just eliminate the EdgeDB additions completely. We'll attack that in a separate PR altogether.

That also breaks the build. I sent the commit without edgedb and broken build to the dev channel

You'll still want to take both the .edgql and .esdl files out of this PR. Edge stuff is being done separately.

CarsonF · 2023-12-11T19:28:52Z

Language.isLanguageOfConsulting seems not the best name since it has the object name in it again.

isUsedForConsulting?
canBeUsedForConsulting?
allowedForConsulting?
consulting?

maybe an enum list would be better to encompass all of these?

Language.allowedUse = ['WiderCommunication', 'Consulting', 'X'];

Though I guess it would be better to describe what this language is vs how the language is allowed to be used in other places.
If we wanted different roles/conditions to be able to assign individual values, then a single list isn't the best way.

bryanjnelson · 2023-12-11T21:27:07Z

Language.isLanguageOfConsulting seems not the best name since it has the object name in it again.

isUsedForConsulting?

canBeUsedForConsulting?

allowedForConsulting?

consulting?

maybe an enum list would be better to encompass all of these?
Language.allowedUse = ['WiderCommunication', 'Consulting', 'X'];
Though I guess it would be better to describe what this language is vs how the language is allowed to be used in other places. If we wanted different roles/conditions to be able to assign individual values, then a single list isn't the best way.

Yeah, after some thought I don't think the allowedUse is the way to go. Which means we're left with a naming decision...I'm leaning toward one of these depending on if we are set on the is prefix or not:

isUsedForConsulting
usedForConsulting

We seem to be inconsistent on the use of is, so I'm not sure what is best here...but those are my thoughts.

adam-soltech · 2023-12-12T21:03:12Z

Though I guess it would be better to describe what this language is vs how the language is allowed to be used in other places. If we wanted different roles/conditions to be able to assign individual values, then a single list isn't the best way.

Also I'd note that a language might be a language of consulting as well as a language of reporting or wider communication so I'm not sure an enum is the way to go. isUsedForConsulting seems better and non-redundant. If that seems good to you let me know and I will make the update

CarsonF · 2023-12-12T21:04:36Z

isUsed seems like the least offensive prefix. I wonder if isUsedWithConsultants would be better than ForConsulting?

bryanjnelson · 2023-12-12T21:15:52Z

isUsed seems like the least offensive prefix. I wonder if isUsedWithConsultants would be better than ForConsulting?

If the UI is going to say "for consulting" then I'd just as soon match that. Not much is gained otherwise imo.

CarsonF · 2023-12-12T21:48:20Z

I guess that's a question for product.

adam-soltech · 2023-12-12T22:10:13Z

isUsed seems like the least offensive prefix. I wonder if isUsedWithConsultants would be better than ForConsulting?

If the UI is going to say "for consulting" then I'd just as soon match that. Not much is gained otherwise imo.

I agree but will run it by product in standup tomorrow

feat: add isLanguageOfConsulting field to Language entity

…iggers (#3022)

fix: subquery for partner fix: subquery for partner

adam-soltech requested a review from CarsonF as a code owner December 6, 2023 20:27

adam-soltech force-pushed the agl/add-is-language-of-consultiung-boolean branch 2 times, most recently from ee65b1f to e7046f4 Compare December 7, 2023 23:18

bryanjnelson requested changes Dec 11, 2023

View reviewed changes

adam-soltech requested a review from bryanjnelson January 25, 2024 18:59

adam-soltech force-pushed the agl/add-is-language-of-consultiung-boolean branch 2 times, most recently from c2e7bf4 to 7820dfa Compare January 26, 2024 19:15

adam-soltech and others added 5 commits March 29, 2024 16:19

fix: conflict

2916b78

fix: e2e tests and dto nullables

89b2b47

feat: add isLanguageOfConsulting field to Language entity

refactor: add edgedb migration for isLanguageOfConsulting

9f0302b

[EdgeDB] Adjust enforcing project context during project insertion tr…

be54d8e

…iggers (#3022)

feat: add language of reporting and wider communication

bef44dc

adam-soltech force-pushed the agl/add-is-language-of-consultiung-boolean branch from 7820dfa to e1907a2 Compare March 29, 2024 23:21

fix: remove typo

4a1b2a1

fix: subquery for partner fix: subquery for partner

adam-soltech force-pushed the agl/add-is-language-of-consultiung-boolean branch from e1907a2 to 4a1b2a1 Compare March 29, 2024 23:34

adam-soltech mentioned this pull request Apr 3, 2024

Agl/language of consulting UI SeedCompany/cord-field#1523

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agl/add is language of consultiung boolean #2983

Agl/add is language of consultiung boolean #2983

adam-soltech commented Dec 6, 2023 •

edited by sync-by-unito bot

github-actions bot commented Dec 6, 2023 •

edited

bryanjnelson left a comment

bryanjnelson Dec 11, 2023

adam-soltech Dec 11, 2023

bryanjnelson Dec 11, 2023

adam-soltech Dec 12, 2023

bryanjnelson Jan 25, 2024

CarsonF commented Dec 11, 2023

bryanjnelson commented Dec 11, 2023

adam-soltech commented Dec 12, 2023

CarsonF commented Dec 12, 2023

bryanjnelson commented Dec 12, 2023

CarsonF commented Dec 12, 2023

adam-soltech commented Dec 12, 2023

Agl/add is language of consultiung boolean #2983

Are you sure you want to change the base?

Agl/add is language of consultiung boolean #2983

Conversation

adam-soltech commented Dec 6, 2023 • edited by sync-by-unito bot

github-actions bot commented Dec 6, 2023 • edited

🗞 GraphQL Summary

⚠️ Dangerous Changes

bryanjnelson left a comment

Choose a reason for hiding this comment

bryanjnelson Dec 11, 2023

Choose a reason for hiding this comment

adam-soltech Dec 11, 2023

Choose a reason for hiding this comment

bryanjnelson Dec 11, 2023

Choose a reason for hiding this comment

adam-soltech Dec 12, 2023

Choose a reason for hiding this comment

bryanjnelson Jan 25, 2024

Choose a reason for hiding this comment

CarsonF commented Dec 11, 2023

bryanjnelson commented Dec 11, 2023

adam-soltech commented Dec 12, 2023

CarsonF commented Dec 12, 2023

bryanjnelson commented Dec 12, 2023

CarsonF commented Dec 12, 2023

adam-soltech commented Dec 12, 2023

adam-soltech commented Dec 6, 2023 •

edited by sync-by-unito bot

github-actions bot commented Dec 6, 2023 •

edited