Treat null scripture input as empty array #2522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with other value handling, even for arrays. User.roles treats null as empty array too via `uniq()`` transform. This fixes `isScriptureEqual` being passed an unexpected null here: https://github.com/SeedCompany/cord-api-v3/blob/5b5fae84facb9da06fbb8d2ecb8af708c0d5a1c8/src/components/product/product.service.ts#L454-L455
|
Yeah tests are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with other value handling, even for arrays. User.roles treats null as empty array too via
uniq()transform.This fixes
isScriptureEqualbeing passed an unexpected null here:cord-api-v3/src/components/product/product.service.ts
Lines 454 to 455 in 5b5fae8
┆Issue is synchronized with this Monday item by Unito