Search by Eth Code and ROD #2518
Open
+57
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarsonF
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Hey @zkhin that's for your initiative here.
I believe if I remember correctly the current search can handle EthnologueLanguage BaseNodes. It's just that they aren't being included the BaseNode labels type filter or have a hydrator. This would be better than adding another GQL/DB query, as another query pushes the burden to the consumer for what's really an API problem.
I was able to quickly test and confirm that my theory. Here's the actions we should take:
EthnologueLanguagecould be added tosearchableAbstracts- Adjust
typesto also include "EthnologueLanguage" if searching for "Language". - Add to
hydratorsa function to hydrate theLanguageobject from an EthnologueLanguage BaseNode/id - Adjust the permission check logic to work with this case.
zkhin
force-pushed
the
feature/2479-search-by-eth-code
branch
from
df61004
to
0a1bf20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2479
┆Issue is synchronized with this Monday item by Unito