Update project and engagement workflow in changeset #2488
Conversation
There was a problem hiding this comment.
I think there's some confusion here. The steps listed in the issue would be going away in the future. We need to add transitions to bypass those listed, conditionally based on whether we are in a changeset.
So for example, instead of Active to DiscussingSuspension, it would be replaced by Active to Suspended.
| @@ -472,6 +472,11 @@ export class ProjectRules { | |||
| type: TransitionType.Neutral, | |||
| label: 'Will Not Change Plan', | |||
| }, | |||
| { | |||
| to: ProjectStep.ActiveChangedPlan, | |||
| type: TransitionType.Changeset, | |||
There was a problem hiding this comment.
It would probably be better to use a separate property here. The transitions inside of changesets still could have "types" so we don't want to block or overload that functionality. Maybe changeset: true or inChangeset: true.
zkhin
force-pushed
the
feature/2480-update-project-engagement-workflow-in-changeset
branch
from
fc8fed2
to
22f7b55
Compare
| @@ -20,6 +20,7 @@ import { | |||
|
|
|||
| interface Transition extends EngagementStatusTransition { | |||
| projectStepRequirements?: ProjectStep[]; | |||
| inChangeset?: boolean; | |||
There was a problem hiding this comment.
Add inChangeset prop and it will have three states now.
true: transition will be available only in changeset modefalse: transition will be available not in changeset mode but in the normal workflowundefined: transition will be available for both workflows.
This should happen automatically when the changeset is approved, but it shouldn't be shown to user
It's the last forward step & this groups the terminate transitions together
Users are free to make these transitions as they are not applied until the changeset is approved by these approvers.
Inside changeset you can do Active -> Suspend -> Active instead of Active -> Suspend -> ActiveChangedPlan
CarsonF
force-pushed
the
feature/2480-update-project-engagement-workflow-in-changeset
branch
from
22f7b55
to
2bc8581
Compare
|
Hey @zkhin I made some changes here. Would you read through my commits and apply the same logic to the engagement workflow? |
Sure, thanks |
Fixes #2480
┆Issue is synchronized with this Monday item by Unito