Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file-loader 5 => 6 (including md5 => md4) #299

Merged
merged 2 commits into from Mar 27, 2020
Merged

file-loader 5 => 6 (including md5 => md4) #299

merged 2 commits into from Mar 27, 2020

Conversation

apepper
Copy link
Contributor

@apepper apepper commented Mar 26, 2020

Breaking changes of version 6 of (file-loader):

use md4 by default for hashing (webpack-contrib/file-loader#369)

Previously file-loader (via loader-utils) used md5 by default. Now it's using md4.

I adjusted contentHash to use js-md4 for preload dump file names.

@apepper
[webpack] file-loader 5 => 6
feaa4a2 
> npm i file-loader@latest

> ⚠ BREAKING CHANGES
> use md4 by default for hashing [previously md5]

Source: https://github.com/webpack-contrib/file-loader/releases/tag/v6.0.0
@apepper
[prerender] contentHash: md5 => md4.
4835030 
Webpack uses md4 for all hashes by default (see [1] and [2])

[1] webpack/webpack#6549
[2] webpack/loader-utils#114
@apepper apepper requested a review from dcsaszar March 26, 2020 12:01
@dcsaszar dcsaszar merged commit 5eb969b into master Mar 27, 2020
@dcsaszar dcsaszar deleted the file-loader_6 branch March 27, 2020 07:19
@apepper apepper changed the title file-loader 5 => 6 file-loader 5 => 6 (including md5 => md4) Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcsaszar dcsaszar Awaiting requested review from dcsaszar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apepper @dcsaszar