Sync with upstream #4
Merged
+23
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Network connections failed when running on the host, so for now
just going back to running the tests in a container;
Timeout connecting to http://localhost:32456/Plugin.Activate
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Need to make the make target smarter to set windows paths;
docker: Error response from daemon: invalid volume specification: '/d/a/go-plugins-helpers/go-plugins-helpers:/go/src/github.com/docker/go-plugins-helpers'.
But probably other changes are needed, so leaving that for later
(Travis also wasn't running on Windows)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
CI: use GitHub Actions
Implements 130 Fixes 126 Signed-off-by: Ivan Andreev <ivandeex@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Put trace logging under control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.