Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Go from 1.17 to 1.20 #10

Merged
merged 3 commits into from
Mar 14, 2023
Merged

feat: update Go from 1.17 to 1.20 #10

merged 3 commits into from
Mar 14, 2023

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 13, 2023

@Soulou I needed to add a go.sum file for the CI to pass. Do you know the reason why we had none in this repository?

@EtienneM EtienneM self-assigned this Mar 13, 2023
Copy link

@aurelien-reeves-scalingo aurelien-reeves-scalingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only go.mod for that one? Is it expected?

Verified

This commit was signed with the committer’s verified signature.
thaJeztah Sebastiaan van Stijn

Verified

This commit was signed with the committer’s verified signature.
thaJeztah Sebastiaan van Stijn
@EtienneM EtienneM force-pushed the release/go/1.20 branch 2 times, most recently from 0644eb5 to 6161e42 Compare March 14, 2023 09:37

Verified

This commit was signed with the committer’s verified signature.
thaJeztah Sebastiaan van Stijn
Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project is solely used by SAND, quite a pain to maintain, but LGTM.

Maybe the code should be integrated actually (that's what I'm saying here)

@EtienneM EtienneM merged commit 47bbcb8 into master Mar 14, 2023
@EtienneM EtienneM deleted the release/go/1.20 branch March 14, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants