ci: Replace macos-latest label with macos-13 #6729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSRBerry
force-pushed
the
fix/macos-runner-label
branch
from
c464b7a
to
54295e9
Compare
Due to a change to the GitHub runner labels a few days ago (see: actions/runner#3256) our build workflows for macOS x64 didn't work anymore. According to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories the macos-13 label is not using arm64 yet. Until a better solution is offered in the linked issue above, we'll keep using the macos-13 label which hopefully doesn't switch to arm64 soon.
TSRBerry
force-pushed
the
fix/macos-runner-label
branch
from
54295e9
to
c324fa9
Compare
riperiperi
approved these changes
Apr 26, 2024
|
I think so too! You'd think they'd at least announce it a few weeks before they roll it out. |
facebook-github-bot
pushed a commit
to facebookresearch/projectaria_tools
that referenced
this pull request
May 2, 2024
Summary: 'macos-latest picks now automatically a mac14-arm' We are fixing here to use macos-13 that continue to use intel based CPU and will provide a way for us to keep a `x86_64` processor to compile our `x86_64` python wheels. We are using similar fix as other communities have done https://github.com/Ryujinx/Ryujinx/pull/6729/files See here for the discussion that happened on exactly the same issue to another GitHub project Ryujinx/Ryujinx#6729 Reviewed By: vijay609 Differential Revision: D56893802 fbshipit-source-id: 4f3163064f5c250dc7b0a86ecaf525cc93e06871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change to the GitHub runner labels a few days ago (see: actions/runner#3256) our build workflows for macOS x64 didn't work anymore. According to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories the macos-13 label is not using arm64 yet.
Until a better solution is offered in the linked issue above, we'll keep using the macos-13 label which hopefully doesn't switch to arm64 soon.