-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable hypervisor by default on macOS #6585
base: master
Are you sure you want to change the base?
Conversation
Stability wise JIT is much superior but there are still some fairly significant performance delta's to HV. Legends Arceus (Town entrance) Breath of the Wild (Tested by adding the hv-fix back) Persona 5 Royal (Station Square) Tears of the Kingdom (Lookout landing) Super Mario Oddssey With that said, the first two games are pretty much unplayable via HV due to freezes so take those results as a best case scenario. The performance hit globally is still quite large, in ToTK in particular it's massive, but the decision I think will swing on what people value more? |
Should we ask for opinions before we merge this? |
A bunch of memory PRs were merged since the last benchmark, so I wanted to test again Game - TOTK, lookout landing IMO - The bigger thing holding back the Ryujinx experience on Mac is the hitching due to shader recompilation, called out in #5713 - but I know thats waiting on a MoltenVK enhancement. |
Some people said that games freeze with hypervisor disabled, other said it fixes those issues, so I can only assume it only works for some people based on that, or maybe it is a red herring and doesn't fix the problem at all. So I dunno what is the better default. At least I think the crashes that some games have with hypervisor enabled are consistently fixed. |
Thanks to #6057 and #6356, most performance and compatibility issues with JIT have been fixed. Since some games freezes randomly when using hypervisor, I believe using JIT is a better default on macOS now. This only changes the default setting, people that already has it enabled or disabled will keep their current setting.
It would be nice to get some confirmation that games generally running better on JIT than hypervisor, or in other words, that this is a good change, I'm doing mainly based on reports of people that had better results with JIT.