elliptic-curve: Allow multiple dsts in the hash2curve API
#1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
hash2curve-multi-dst
branch
from
3744148
to
9efa183
Compare
This was referenced Feb 1, 2023
Merged
|
@daxpedda if you can update https://github.com/RustCrypto/elliptic-curves that'd be great. It's pulling in |
|
On it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1175 got merged I attempted to go ahead and update voprf and opaque-ke, but quickly hit the same problem that required #876.
The change to the OPRF ID now being a string instead of a byte made it impossible to generate a fixed size array to hold the DST. So I decided to apply the same solution I did in #876.
There are only two changes:
&[&[u8]]instead of&[u8]as thedstparameter.ExpandMsgXmdnow requiresDefault + FixedOutput + HashMarkerinstead ofDigest.