Add SavedAsPointer and it's mutable part as trait #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SavedAsPointer is a trait for types which are saving a direct pointer from the C side as a rust Wrapper. Signed-off-by: Finn Behrens <me@kloenk.de>
wedsonaf
reviewed
Jul 24, 2021
| @@ -247,3 +247,52 @@ impl<T: FnOnce()> Drop for ScopeGuard<T> { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| /// Trait for wrappers which are holding a direct pointer that they are getting from a C side function. | |||
| pub trait SavedAsPointer { | |||
There was a problem hiding this comment.
Is there a reason why you can't use PointerWrapper? We should unify all these pointer wrappers.
There was a problem hiding this comment.
My Understanding of PointerWrapper is that it is designed for rust types which can be given to a C interface. The trait I am implementing is designed to hold a pointer which got allocated via a C api.
There was a problem hiding this comment.
@wedsonaf is my understanding of PointerWrapper correct? if not, should I withdraw this pr?
|
This is similar to #557 but that does not implement the get_internal functions. closing it, as it got stall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used for NetDevice and NlAttr wrappers in #439