Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1048:wait_listNameChange #1049

Open
wants to merge 2 commits into
base: rust-next
Choose a base branch
from

Conversation

AdilDyer
Copy link

fixes:#1048

@y86-dev
Copy link
Collaborator

y86-dev commented Dec 13, 2023

Hi @AdilDyer,

thanks for your patch. Have you taken a look at https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing?

Because you will need to send this as a patch via mail to the Rust-for-Linux mailing list.

Note that you also have to write a commit message. And I also noticed that you have two commits (one is a merge commit), can you make sure that you only have one?

The patch itself LGTM.

@AdilDyer
Copy link
Author

AdilDyer commented Dec 15, 2023

@y86-dev Ok thanks for guiding , have sent this pr's link along with details to the concerned email.

@ojeda
Copy link
Member

ojeda commented Dec 15, 2023

have sent this pr's link

Please note that it is not this PR link that you have to send, but the patches.

along with details to the concerned email.

There are several emails that you need to send it to -- what do you mean by "to the concerned email"?

In any case, I think your email did not arrive to the archive: https://lore.kernel.org/rust-for-linux/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants