Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better parsing of header #27

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Better parsing of header #27

merged 7 commits into from
Sep 5, 2023

Commits on Aug 16, 2023

  1. Add tests for quoted comma case

    @MrCurtis
    MrCurtis committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    72b6550 View commit details
    Browse the repository at this point in the history

  2. Add regex dependency

    @MrCurtis
    MrCurtis committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8d5597c View commit details
    Browse the repository at this point in the history

  3. Split using regex

    @MrCurtis
    MrCurtis committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1b5bba5 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary capture from regex

    @MrCurtis
    MrCurtis committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    cf12c1d View commit details
    Browse the repository at this point in the history

  5. Trim off quotes

    @MrCurtis
    MrCurtis committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a8164a7 View commit details
    Browse the repository at this point in the history

  6. Add explanation for regex

    @MrCurtis
    MrCurtis committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    9f37813 View commit details
    Browse the repository at this point in the history

  7. Make regex static ref. 

    This avoids repeatedly compiling the regex each call to parse.
    @MrCurtis
    MrCurtis committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4143189 View commit details
    Browse the repository at this point in the history