Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Update to Cake v4.0.0 #58

Closed
wants to merge 1 commit into from

Conversation

JegDudley
Copy link

Updated the following NuGet packages:

  • Cake.Common = v3.0.0 → v4.0.0

  • Cake.Testing = v3.0.0 → v4.0.0

  • FluentAssertions = v6.7.0 → v6.12.0

  • Microsoft.NET.Test.Sdk = v17.3.0 → v17.9.0

  • Microsoft.SourceLink.GitHub = v1.1.1 → v8.0.0

  • Nerdbank.GitVersioning = v3.5.109 → v3.6.133

  • xunit = v2.4.2 → v2.7.0

  • xunit.runner.visualstudio = v2.4.5 → v2.5.7

After changes, both projects build successfully and all no.3 unit tests pass.

(Apologies if I've done anything wrong in this commit, this is sort of my first pull request to a public repo.)

(And great project, btw... thanks for providing it! ⭐)

- Cake.Common = v3.0.0 → v4.0.0
- Cake.Testing = v3.0.0 → v4.0.0

- FluentAssertions = v6.7.0 → v6.12.0

- Microsoft.NET.Test.Sdk = v17.3.0 → v17.9.0
- Microsoft.SourceLink.GitHub = v1.1.1 → v8.0.0

- Nerdbank.GitVersioning = v3.5.109 → v3.6.133

- xunit = v2.4.2 → v2.7.0
- xunit.runner.visualstudio = v2.4.5 → v2.5.7
@Romanx
Copy link
Owner

Romanx commented Mar 7, 2024

Hey @JegDudley thanks for taking a look at this. I'll take a look later today and try get a release out 👍

@Romanx Romanx mentioned this pull request Mar 9, 2024
@Romanx Romanx closed this in #59 Mar 9, 2024
@Romanx
Copy link
Owner

Romanx commented Mar 9, 2024

@JegDudley thanks for the making PR.

While looking at the updates i found some other changes that I wanted to make to bring the project up to date and didn't want to change your branch. I've merged another found at #59. A release will be out shortly with the changes as version 4.0.1. Let me know if you have any issues 👍

@JegDudley
Copy link
Author

Thanks for the effort @Romanx -- I've downloaded and will start using it today. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants