Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make a minor breaking change to lintpaths, removing the AllPaths property. #1491

Merged
merged 3 commits into from
Jan 28, 2025
Merged

make a minor breaking change to lintpaths, removing the AllPaths property. #1491

merged 3 commits into from
Jan 28, 2025
+61 −102

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll
make a minor breaking change to lintpaths, removing the AllPaths pr…

Verified

This commit was signed with the committer’s verified signature.
fatso83 Carl-Erik Kopseng
SSH Key Fingerprint: 67hw/H9QTbRYNl1n/xxhbB76lPm88yhyuVfIjxIWE1U
Verified
Learn about vigilant mode
Loading
Loading status checks…
861a97b 
…operty.

 Instead a trigger none build will just populate the paths from there. This keeps most of the behavior but helps de-duplicate the code and simplify the logic.
@github-actions github-actions bot added this to the v2.9.10 milestone Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Test Results

2 files  ±0  2 suites  ±0   2s ⏱️ -1s
3 tests ±0  3 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8ea0c53. ± Comparison against base commit b731ea8.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Summary

Summary
Generated on: 01/28/2025 - 01:41:45
Coverage date: 01/28/2025 - 01:41:43
Parser: Cobertura
Assemblies: 2
Classes: 165
Files: 164
Line coverage: 0.7% (34 of 4571)
Covered lines: 34
Uncovered lines: 4537
Coverable lines: 4571
Total lines: 10593
Branch coverage: 0% (1 of 1236)
Covered branches: 1
Total branches: 1236
Method coverage: Feature is only available for sponsors
Tag: 2.9.10-pr1491.16+Branch.pull-1491-merge.Sha.179f55078f7612dc4d9a372d06938e3029c312f3

Coverage

Rocket.Surgery.Nuke - 0.3%
Name Line Branch
Rocket.Surgery.Nuke 0.3% 0%
Rocket.Surgery.Nuke.Arguments 0% 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesParameter 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesStep 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesSteps 0% 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesTasks 0% 0%
Rocket.Surgery.Nuke.AzurePipelinesStepsAttribute 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.ContinuousIntegrationConventionsA
ttribute		 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.ICIEnvironment 0%
Rocket.Surgery.Nuke.ContinuousIntegration.PrintBuildVersionAttribute 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.PrintCIEnvironmentAttribute 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.UploadLogsAttribute 0% 0%
Rocket.Surgery.Nuke.DotNetCore.ICanBuildWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanDotNetFormat 0% 0%
Rocket.Surgery.Nuke.DotNetCore.ICanPackWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanRestoreWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanTestWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanTestWithDotNetCoreBuild 0%
Rocket.Surgery.Nuke.DotNetTool 0% 0%
Rocket.Surgery.Nuke.DotNetToolAttribute 0%
Rocket.Surgery.Nuke.DownloadFileAttribute 0% 0%
Rocket.Surgery.Nuke.EnsureGitHooksAttribute 0% 0%
Rocket.Surgery.Nuke.EnsurePackageSourceHasCredentialsAttribute 9% 0%
Rocket.Surgery.Nuke.Extensions 0% 0%
Rocket.Surgery.Nuke.FilePathExtensions 0% 0%
Rocket.Surgery.Nuke.FullToolCommandDefinition 0%
Rocket.Surgery.Nuke.GithubActions.BaseGitHubActionsStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.CheckoutStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.CustomFileWriterExtensions 0% 0%
Rocket.Surgery.Nuke.GithubActions.DownloadArtifactStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionCondition 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsEnvironmentVariable 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsEnvironmentVariableAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionsExtensions 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionShell 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsInput 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsInputAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsLintAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionsNukeParameter 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsOutput 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsPermissions 0% 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsSecret 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsSecretAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsStepOutput 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsStepsAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionsStepsAttributeBase 0% 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsVariable 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsVariableAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsWorkflowOutput 0%
Rocket.Surgery.Nuke.GithubActions.HeadlessRunStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordConnectServerSecret 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordConnectServerSecretAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordSecret 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordSecretAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordServiceAccountSecret 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordServiceAccountSecretAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonGitHubActionsConfiguration 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonGitHubActionsVcsTrigger 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonGitHubActionsWorkflowTrigger 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsConcurrency 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsDefaults 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsDefaultsRun 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsJob 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsJobBase 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubWorkflowJob 0%
Rocket.Surgery.Nuke.GithubActions.RunStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.SetupDotNetStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.StickyPullRequestStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.TriggerValueAttribute 0%
Rocket.Surgery.Nuke.GithubActions.UploadArtifactStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.UsingStep 0% 0%
Rocket.Surgery.Nuke.GitVersionFunctions 0% 0%
Rocket.Surgery.Nuke.Helpers 0%
Rocket.Surgery.Nuke.HuskyEngine 0% 0%
Rocket.Surgery.Nuke.ICanClean 0%
Rocket.Surgery.Nuke.ICanLint 0% 0%
Rocket.Surgery.Nuke.ICanPrettier 0% 0%
Rocket.Surgery.Nuke.ICanRegenerateBuildConfiguration 0%
Rocket.Surgery.Nuke.ICanUpdateReadme 0%
Rocket.Surgery.Nuke.ICanUpdateSolution 0%
Rocket.Surgery.Nuke.IComprehendSamples 0%
Rocket.Surgery.Nuke.IComprehendSources 0%
Rocket.Surgery.Nuke.IComprehendTemplates 0%
Rocket.Surgery.Nuke.IComprehendTests 0% 0%
Rocket.Surgery.Nuke.IGenerateCodeCoverageBadges 0%
Rocket.Surgery.Nuke.IGenerateCodeCoverageReport 0%
Rocket.Surgery.Nuke.IGenerateCodeCoverageSummary 0%
Rocket.Surgery.Nuke.IGenerateDocFx 0%
Rocket.Surgery.Nuke.IHaveArtifacts 0% 0%
Rocket.Surgery.Nuke.IHaveBuildVersion 0%
Rocket.Surgery.Nuke.IHaveCodeCoverage 0% 0%
Rocket.Surgery.Nuke.IHaveConfiguration 0%
Rocket.Surgery.Nuke.IHaveDocs 0%
Rocket.Surgery.Nuke.IHaveEnableRestore 0% 0%
Rocket.Surgery.Nuke.IHaveNuGetPackages 0%
Rocket.Surgery.Nuke.IHaveOutputArtifacts 0%
Rocket.Surgery.Nuke.IHaveOutputLogs 0%
Rocket.Surgery.Nuke.IHavePublicApis 0% 0%
Rocket.Surgery.Nuke.IHavePublishArtifacts 0%
Rocket.Surgery.Nuke.IHaveSolution 0%
Rocket.Surgery.Nuke.IHaveTestArtifacts 0%
Rocket.Surgery.Nuke.ITriggerCodeCoverageReports 0% 0%
Rocket.Surgery.Nuke.Jobs.CloseMilestoneJobAttribute 0%
Rocket.Surgery.Nuke.Jobs.DraftReleaseJobAttribute 0%
Rocket.Surgery.Nuke.Jobs.PublishNugetPackagesJobAttribute 0% 0%
Rocket.Surgery.Nuke.Jobs.UpdateMilestoneJobAttribute 0%
Rocket.Surgery.Nuke.Jobs.WorkflowHelpers 0% 0%
Rocket.Surgery.Nuke.LintPaths 0% 0%
Rocket.Surgery.Nuke.LocalBuildConventionsAttribute 0%
Rocket.Surgery.Nuke.MsBuild.ICanBuildWithMsBuild 0%
Rocket.Surgery.Nuke.MsBuild.ICanPackWithMsBuild 0%
Rocket.Surgery.Nuke.MsBuild.ICanRestoreWithMsBuild 0%
Rocket.Surgery.Nuke.MsBuild.ICanTestWithXUnit 0%
Rocket.Surgery.Nuke.NuGetVerbosityMappingAttribute 100%
Rocket.Surgery.Nuke.PackageIconAttribute 0% 0%
Rocket.Surgery.Nuke.ProjectModel.MsbItem 0%
Rocket.Surgery.Nuke.ProjectModel.MsbItemMetadata 0%
Rocket.Surgery.Nuke.ProjectModel.MsbPackageReference 0% 0%
Rocket.Surgery.Nuke.ProjectModel.MsbProject 0% 0%
Rocket.Surgery.Nuke.ProjectModel.MsbProperty 0%
Rocket.Surgery.Nuke.ProjectModel.MsbSolution 0%
Rocket.Surgery.Nuke.ProjectModel.NukeSolutionExtensions 12.5% 5%
Rocket.Surgery.Nuke.Readme.AppVeyorHistory 0%
Rocket.Surgery.Nuke.Readme.AzurePipelinesHistory 0%
Rocket.Surgery.Nuke.Readme.Badges 0% 0%
Rocket.Surgery.Nuke.Readme.CodacySection 0% 0%
Rocket.Surgery.Nuke.Readme.CodecovSection 0%
Rocket.Surgery.Nuke.Readme.GitHubActionsHistory 0%
Rocket.Surgery.Nuke.Readme.GithubLicenseSection 0%
Rocket.Surgery.Nuke.Readme.GithubReleaseSection 0%
Rocket.Surgery.Nuke.Readme.Histories 0% 0%
Rocket.Surgery.Nuke.Readme.NugetPackagesSection 0% 0%
Rocket.Surgery.Nuke.Readme.ReadmeAttribute 0%
Rocket.Surgery.Nuke.Readme.ReadmeUpdater 0%
Rocket.Surgery.Nuke.Readme.References 0% 0%
Rocket.Surgery.Nuke.Readme.Sections 0%
Rocket.Surgery.Nuke.ResolvedToolsManifest 0% 0%
Rocket.Surgery.Nuke.Settings 0%
Rocket.Surgery.Nuke.SolutionExtensions 0% 0%
Rocket.Surgery.Nuke.SolutionUpdater 0% 0%
Rocket.Surgery.Nuke.SolutionUpdaterConfigurationAttribute 0% 0%
Rocket.Surgery.Nuke.StringExtensions 0%
Rocket.Surgery.Nuke.Symbols 0% 0%
Rocket.Surgery.Nuke.TargetAttributeCache 0% 0%
Rocket.Surgery.Nuke.TargetAttributeCache.CacheItem 0%
Rocket.Surgery.Nuke.TestMethodExtensions 0% 0%
Rocket.Surgery.Nuke.TitleEventsAttribute 0% 0%
Rocket.Surgery.Nuke.ToolDefinition 0%
Rocket.Surgery.Nuke.ToolSettingsExtensions 0% 0%
Rocket.Surgery.Nuke.ToolsManifset 0%
Rocket.Surgery.Nuke.Xamarin.ICanArchiveiOS 0%
Rocket.Surgery.Nuke.Xamarin.ICanBuildXamarin 0%
Rocket.Surgery.Nuke.Xamarin.ICanBuildXamariniOS 0%
Rocket.Surgery.Nuke.Xamarin.ICanBuildXamarinMac 0%
Rocket.Surgery.Nuke.Xamarin.ICanPackXamariniOS 0%
Rocket.Surgery.Nuke.Xamarin.ICanRestoreXamarin 0%
Rocket.Surgery.Nuke.Xamarin.ICanTestXamarin 0%
Rocket.Surgery.Nuke.Xamarin.IHaveBundleIdentifier 0% 0%
Rocket.Surgery.Nuke.Xamarin.IHaveIpa 0% 0%
Rocket.Surgery.Nuke.Xamarin.IHavePackXamarinMac 0%
Rocket.Surgery.Nuke.Xamarin.IXamarinAppleTarget 0%
Rocket.Surgery.Nuke.Xamarin.Plist 0% 0%
Rocket.Surgery.Nuke.Xamarin.TargetPlatform 0%
Rocket.Surgery.Nuke.Xamarin.XamarinConfiguration 0%
Rocket.Surgery.Nuke.Tests - 100%
Name Line Branch
Rocket.Surgery.Nuke.Tests 100% ****
Rocket.Surgery.Nuke.Tests.GitVersionTests 100%
Rocket.Surgery.Nuke.Tests.MiscTests 100%

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 0.72%. Comparing base (b731ea8) to head (8ea0c53).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/Nuke/DotNetCore/ICanDotNetFormat.cs 0.00% 22 Missing ⚠️
src/Nuke/LintPaths.cs 0.00% 14 Missing ⚠️
src/Nuke/ICanPrettier.cs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1491   +/-   ##
======================================
  Coverage    0.71%   0.72%           
======================================
  Files         164     164           
  Lines        4624    4570   -54     
  Branches      378     377    -1     
======================================
  Hits           33      33           
+ Misses       4590    4536   -54     
  Partials        1       1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-driscoll david-driscoll merged commit 5dd0243 into master Jan 28, 2025
6 checks passed
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Jan 28, 2025
@github-actions github-actions bot modified the milestones: v2.9.10, v2.9.11 Jan 28, 2025
@github-actions github-actions bot modified the milestones: v2.9.11, v2.9.12 Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ mysterious We forgot to label this
Projects
None yet
Milestone
v2.9.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-driscoll @rsg-bot