Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial work on fixing lint on windows #1465

Merged
merged 17 commits into from
Dec 31, 2024
Merged

initial work on fixing lint on windows #1465

merged 17 commits into from
Dec 31, 2024
+3,508 −3,476

Conversation

david-driscoll
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the v2.9.8 milestone Dec 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

Test Results

2 files  ±0  2 suites  ±0   1s ⏱️ ±0s
3 tests ±0  3 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 82ca23c. ± Comparison against base commit c31ec72.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 30, 2024 •
edited
Loading

Summary

Summary
Generated on: 12/31/2024 - 17:13:39
Coverage date: 12/31/2024 - 17:13:37
Parser: Cobertura
Assemblies: 2
Classes: 165
Files: 164
Line coverage: 0.7% (34 of 4622)
Covered lines: 34
Uncovered lines: 4588
Coverable lines: 4622
Total lines: 10642
Branch coverage: 0% (1 of 1238)
Covered branches: 1
Total branches: 1238
Method coverage: Feature is only available for sponsors
Tag: 2.9.8-pr1465.22+Branch.pull-1465-merge.Sha.68287c4a96e3b66a1dbf06c02ed3616dd322674b

Coverage

Rocket.Surgery.Nuke - 0.3%
Name Line Branch
Rocket.Surgery.Nuke 0.3% 0%
Rocket.Surgery.Nuke.Arguments 0% 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesParameter 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesStep 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesSteps 0% 0%
Rocket.Surgery.Nuke.Azp.AzurePipelinesTasks 0% 0%
Rocket.Surgery.Nuke.AzurePipelinesStepsAttribute 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.ContinuousIntegrationConventionsA
ttribute		 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.ICIEnvironment 0%
Rocket.Surgery.Nuke.ContinuousIntegration.PrintBuildVersionAttribute 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.PrintCIEnvironmentAttribute 0% 0%
Rocket.Surgery.Nuke.ContinuousIntegration.UploadLogsAttribute 0% 0%
Rocket.Surgery.Nuke.DotNetCore.ICanBuildWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanDotNetFormat 0% 0%
Rocket.Surgery.Nuke.DotNetCore.ICanPackWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanRestoreWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanTestWithDotNetCore 0%
Rocket.Surgery.Nuke.DotNetCore.ICanTestWithDotNetCoreBuild 0%
Rocket.Surgery.Nuke.DotNetTool 0% 0%
Rocket.Surgery.Nuke.DotNetToolAttribute 0%
Rocket.Surgery.Nuke.DownloadFileAttribute 0% 0%
Rocket.Surgery.Nuke.EnsureGitHooksAttribute 0% 0%
Rocket.Surgery.Nuke.EnsurePackageSourceHasCredentialsAttribute 9% 0%
Rocket.Surgery.Nuke.Extensions 0% 0%
Rocket.Surgery.Nuke.FilePathExtensions 0% 0%
Rocket.Surgery.Nuke.FullToolCommandDefinition 0%
Rocket.Surgery.Nuke.GithubActions.BaseGitHubActionsStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.CheckoutStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.CustomFileWriterExtensions 0% 0%
Rocket.Surgery.Nuke.GithubActions.DownloadArtifactStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionCondition 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsEnvironmentVariable 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsEnvironmentVariableAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionsExtensions 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionShell 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsInput 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsInputAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsLintAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionsNukeParameter 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsOutput 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsPermissions 0% 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsSecret 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsSecretAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsStepOutput 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsStepsAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.GithubActionsStepsAttributeBase 0% 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsVariable 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsVariableAttribute 0%
Rocket.Surgery.Nuke.GithubActions.GitHubActionsWorkflowOutput 0%
Rocket.Surgery.Nuke.GithubActions.HeadlessRunStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordConnectServerSecret 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordConnectServerSecretAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordSecret 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordSecretAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordServiceAccountSecret 0% 0%
Rocket.Surgery.Nuke.GithubActions.OnePasswordServiceAccountSecretAttribute 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonGitHubActionsConfiguration 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonGitHubActionsVcsTrigger 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonGitHubActionsWorkflowTrigger 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsConcurrency 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsDefaults 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsDefaultsRun 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsJob 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubActionsJobBase 0% 0%
Rocket.Surgery.Nuke.GithubActions.RocketSurgeonsGithubWorkflowJob 0%
Rocket.Surgery.Nuke.GithubActions.RunStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.SetupDotNetStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.StickyPullRequestStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.TriggerValueAttribute 0%
Rocket.Surgery.Nuke.GithubActions.UploadArtifactStep 0% 0%
Rocket.Surgery.Nuke.GithubActions.UsingStep 0% 0%
Rocket.Surgery.Nuke.GitVersionFunctions 0% 0%
Rocket.Surgery.Nuke.Helpers 0%
Rocket.Surgery.Nuke.HuskyEngine 0% 0%
Rocket.Surgery.Nuke.ICanClean 0%
Rocket.Surgery.Nuke.ICanLint 0% 0%
Rocket.Surgery.Nuke.ICanPrettier 0% 0%
Rocket.Surgery.Nuke.ICanRegenerateBuildConfiguration 0%
Rocket.Surgery.Nuke.ICanUpdateReadme 0%
Rocket.Surgery.Nuke.ICanUpdateSolution 0%
Rocket.Surgery.Nuke.IComprehendSamples 0%
Rocket.Surgery.Nuke.IComprehendSources 0%
Rocket.Surgery.Nuke.IComprehendTemplates 0%
Rocket.Surgery.Nuke.IComprehendTests 0% 0%
Rocket.Surgery.Nuke.IGenerateCodeCoverageBadges 0%
Rocket.Surgery.Nuke.IGenerateCodeCoverageReport 0%
Rocket.Surgery.Nuke.IGenerateCodeCoverageSummary 0%
Rocket.Surgery.Nuke.IGenerateDocFx 0%
Rocket.Surgery.Nuke.IHaveArtifacts 0% 0%
Rocket.Surgery.Nuke.IHaveBuildVersion 0%
Rocket.Surgery.Nuke.IHaveCodeCoverage 0% 0%
Rocket.Surgery.Nuke.IHaveConfiguration 0%
Rocket.Surgery.Nuke.IHaveDocs 0%
Rocket.Surgery.Nuke.IHaveEnableRestore 0% 0%
Rocket.Surgery.Nuke.IHaveNuGetPackages 0%
Rocket.Surgery.Nuke.IHaveOutputArtifacts 0%
Rocket.Surgery.Nuke.IHaveOutputLogs 0%
Rocket.Surgery.Nuke.IHavePublicApis 0% 0%
Rocket.Surgery.Nuke.IHavePublishArtifacts 0%
Rocket.Surgery.Nuke.IHaveSolution 0%
Rocket.Surgery.Nuke.IHaveTestArtifacts 0%
Rocket.Surgery.Nuke.ITriggerCodeCoverageReports 0% 0%
Rocket.Surgery.Nuke.Jobs.CloseMilestoneJobAttribute 0%
Rocket.Surgery.Nuke.Jobs.DraftReleaseJobAttribute 0%
Rocket.Surgery.Nuke.Jobs.PublishNugetPackagesJobAttribute 0% 0%
Rocket.Surgery.Nuke.Jobs.UpdateMilestoneJobAttribute 0%
Rocket.Surgery.Nuke.Jobs.WorkflowHelpers 0% 0%
Rocket.Surgery.Nuke.LintPaths 0% 0%
Rocket.Surgery.Nuke.LocalBuildConventionsAttribute 0%
Rocket.Surgery.Nuke.MsBuild.ICanBuildWithMsBuild 0%
Rocket.Surgery.Nuke.MsBuild.ICanPackWithMsBuild 0%
Rocket.Surgery.Nuke.MsBuild.ICanRestoreWithMsBuild 0%
Rocket.Surgery.Nuke.MsBuild.ICanTestWithXUnit 0%
Rocket.Surgery.Nuke.NuGetVerbosityMappingAttribute 100%
Rocket.Surgery.Nuke.PackageIconAttribute 0% 0%
Rocket.Surgery.Nuke.ProjectModel.MsbItem 0%
Rocket.Surgery.Nuke.ProjectModel.MsbItemMetadata 0%
Rocket.Surgery.Nuke.ProjectModel.MsbPackageReference 0% 0%
Rocket.Surgery.Nuke.ProjectModel.MsbProject 0% 0%
Rocket.Surgery.Nuke.ProjectModel.MsbProperty 0%
Rocket.Surgery.Nuke.ProjectModel.MsbSolution 0%
Rocket.Surgery.Nuke.ProjectModel.NukeSolutionExtensions 12.5% 5%
Rocket.Surgery.Nuke.Readme.AppVeyorHistory 0%
Rocket.Surgery.Nuke.Readme.AzurePipelinesHistory 0%
Rocket.Surgery.Nuke.Readme.Badges 0% 0%
Rocket.Surgery.Nuke.Readme.CodacySection 0% 0%
Rocket.Surgery.Nuke.Readme.CodecovSection 0%
Rocket.Surgery.Nuke.Readme.GitHubActionsHistory 0%
Rocket.Surgery.Nuke.Readme.GithubLicenseSection 0%
Rocket.Surgery.Nuke.Readme.GithubReleaseSection 0%
Rocket.Surgery.Nuke.Readme.Histories 0% 0%
Rocket.Surgery.Nuke.Readme.NugetPackagesSection 0% 0%
Rocket.Surgery.Nuke.Readme.ReadmeAttribute 0%
Rocket.Surgery.Nuke.Readme.ReadmeUpdater 0%
Rocket.Surgery.Nuke.Readme.References 0% 0%
Rocket.Surgery.Nuke.Readme.Sections 0%
Rocket.Surgery.Nuke.ResolvedToolsManifest 0% 0%
Rocket.Surgery.Nuke.Settings 0%
Rocket.Surgery.Nuke.SolutionExtensions 0% 0%
Rocket.Surgery.Nuke.SolutionUpdater 0% 0%
Rocket.Surgery.Nuke.SolutionUpdaterConfigurationAttribute 0% 0%
Rocket.Surgery.Nuke.StringExtensions 0%
Rocket.Surgery.Nuke.Symbols 0% 0%
Rocket.Surgery.Nuke.TargetAttributeCache 0% 0%
Rocket.Surgery.Nuke.TargetAttributeCache.CacheItem 0%
Rocket.Surgery.Nuke.TestMethodExtensions 0% 0%
Rocket.Surgery.Nuke.TitleEventsAttribute 0% 0%
Rocket.Surgery.Nuke.ToolDefinition 0%
Rocket.Surgery.Nuke.ToolSettingsExtensions 0% 0%
Rocket.Surgery.Nuke.ToolsManifset 0%
Rocket.Surgery.Nuke.Xamarin.ICanArchiveiOS 0%
Rocket.Surgery.Nuke.Xamarin.ICanBuildXamarin 0%
Rocket.Surgery.Nuke.Xamarin.ICanBuildXamariniOS 0%
Rocket.Surgery.Nuke.Xamarin.ICanBuildXamarinMac 0%
Rocket.Surgery.Nuke.Xamarin.ICanPackXamariniOS 0%
Rocket.Surgery.Nuke.Xamarin.ICanRestoreXamarin 0%
Rocket.Surgery.Nuke.Xamarin.ICanTestXamarin 0%
Rocket.Surgery.Nuke.Xamarin.IHaveBundleIdentifier 0% 0%
Rocket.Surgery.Nuke.Xamarin.IHaveIpa 0% 0%
Rocket.Surgery.Nuke.Xamarin.IHavePackXamarinMac 0%
Rocket.Surgery.Nuke.Xamarin.IXamarinAppleTarget 0%
Rocket.Surgery.Nuke.Xamarin.Plist 0% 0%
Rocket.Surgery.Nuke.Xamarin.TargetPlatform 0%
Rocket.Surgery.Nuke.Xamarin.XamarinConfiguration 0%
Rocket.Surgery.Nuke.Tests - 100%
Name Line Branch
Rocket.Surgery.Nuke.Tests 100% ****
Rocket.Surgery.Nuke.Tests.GitVersionTests 100%
Rocket.Surgery.Nuke.Tests.MiscTests 100%

@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.61162% with 1300 lines in your changes missing coverage. Please review.

Project coverage is 0.71%. Comparing base (c31ec72) to head (82ca23c).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
src/Nuke/DotNetCore/ICanDotNetFormat.cs 0.00% 157 Missing ⚠️
src/Nuke/TestMethodExtensions.cs 0.00% 86 Missing ⚠️
src/Nuke/SolutionUpdater.cs 0.00% 79 Missing ⚠️
src/Nuke/Extensions.cs 0.00% 68 Missing ⚠️
src/Nuke/ICanLint.cs 0.00% 65 Missing ⚠️
src/Nuke/GithubActions/GithubActionsExtensions.cs 0.00% 62 Missing ⚠️
src/Nuke/Xamarin/apple/Plist.cs 0.00% 58 Missing ⚠️
src/Nuke/LintPaths.cs 0.00% 37 Missing ⚠️
src/Nuke/ITriggerCodeCoverageReports.cs 0.00% 34 Missing ⚠️
src/Nuke/Arguments.cs 0.00% 33 Missing ⚠️
... and 78 more
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #1465      +/-   ##
=========================================
+ Coverage    0.65%   0.71%   +0.06%     
=========================================
  Files         164     164              
  Lines        4892    4621     -271     
  Branches      392     378      -14     
=========================================
+ Hits           32      33       +1     
+ Misses       4859    4587     -272     
  Partials        1       1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-driscoll david-driscoll force-pushed the fix/lint branch 19 times, most recently from 8b19263 to 8392f21 Compare December 31, 2024 01:10
@david-driscoll
initial work on fixing lint on windows

Verified

This commit was signed with the committer’s verified signature.
david-driscoll David Driscoll
SSH Key Fingerprint: TrcTeea1DU/915HcMnjIG//NwkgWlNnOhv/irZTDqis
Verified
Learn about vigilant mode
Loading
Loading status checks…
be5eb08
@david-driscoll
removed debugger display

Verified

This commit was signed with the committer’s verified signature.
david-driscoll David Driscoll
SSH Key Fingerprint: TrcTeea1DU/915HcMnjIG//NwkgWlNnOhv/irZTDqis
Verified
Learn about vigilant mode
Loading
Loading status checks…
4dd6a32
@david-driscoll
first draft of running the updated editorconfig

Verified

This commit was signed with the committer’s verified signature.
david-driscoll David Driscoll
SSH Key Fingerprint: TrcTeea1DU/915HcMnjIG//NwkgWlNnOhv/irZTDqis
Verified
Learn about vigilant mode
Loading
Loading status checks…
d58d2fa
rsg-bot and others added 6 commits December 30, 2024 22:25
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e5564ca
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
50548d3
@david-driscoll
Updated final config

Verified

This commit was signed with the committer’s verified signature.
david-driscoll David Driscoll
SSH Key Fingerprint: TrcTeea1DU/915HcMnjIG//NwkgWlNnOhv/irZTDqis
Verified
Learn about vigilant mode
Loading
Loading status checks…
087933d
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
9a96a9a
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
77a5394
@david-driscoll
removed extra code

Verified

This commit was signed with the committer’s verified signature.
david-driscoll David Driscoll
SSH Key Fingerprint: TrcTeea1DU/915HcMnjIG//NwkgWlNnOhv/irZTDqis
Verified
Learn about vigilant mode
Loading
Loading status checks…
f073209
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
8ebe591
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
89d4c7d
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
4a7e03a
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e117754
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
21ace2e
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
ee8cd80
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6d1737c
@rsg-bot
Automatically linting code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
82ca23c
@david-driscoll david-driscoll merged commit 7f7c1ab into master Dec 31, 2024
8 of 9 checks passed
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ mysterious We forgot to label this
Projects
None yet
Milestone
v2.9.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@david-driscoll @rsg-bot