Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lets make this work #1302

Merged
merged 9 commits into from
Sep 3, 2024
Merged

lets make this work #1302

merged 9 commits into from
Sep 3, 2024

Conversation

david-driscoll
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature.
lifeofguenter Günter Grodotzki
@github-actions github-actions bot added this to the v1.8.37 milestone Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 6.16246% with 335 lines in your changes missing coverage. Please review.

Project coverage is 7.98%. Comparing base (31b4293) to head (be86f64).

Files with missing lines Patch % Lines
src/Nuke/ProjectModel/ProjectAnalyzerModel.cs 8.05% 137 Missing ⚠️
src/Nuke/DotNetCore/ICanTestWithDotNetCoreBuild.cs 0.00% 50 Missing ⚠️
src/Nuke/TargetAttributeCache.cs 6.12% 46 Missing ⚠️
src/Nuke/ProjectModel/BuildalyzerExtensions.cs 0.00% 21 Missing ⚠️
src/Nuke/Extensions.cs 20.83% 19 Missing ⚠️
src/Nuke/ICanUpdateSolution.cs 0.00% 19 Missing ⚠️
src/Nuke/IHavePublicApis.cs 6.25% 15 Missing ⚠️
src/Nuke/ICanRegenerateBuildConfiguration.cs 0.00% 7 Missing ⚠️
src/Nuke/DotNetCore/ICanRestoreWithDotNetCore.cs 0.00% 4 Missing ⚠️
...e/GithubActions/GithubActionsStepsAttributeBase.cs 0.00% 4 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1302      +/-   ##
=========================================
- Coverage    8.09%   7.98%   -0.12%     
=========================================
  Files         147     149       +2     
  Lines        3879    4034     +155     
  Branches      303     311       +8     
=========================================
+ Hits          314     322       +8     
- Misses       3565    3712     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was signed with the committer’s verified signature.
lifeofguenter Günter Grodotzki

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
lifeofguenter Günter Grodotzki
@david-driscoll david-driscoll merged commit 76c9c3b into master Sep 3, 2024
6 of 8 checks passed
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Sep 3, 2024
@github-actions github-actions bot modified the milestones: v1.8.37, v2.8.0, v2.8.1 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant