Disabling built in msbuild & revamping linting using Husky.Net #1299
+1,262
−557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1299 +/- ##
=========================================
- Coverage 8.14% 7.95% -0.20%
=========================================
Files 146 147 +1
Lines 3632 3832 +200
Branches 285 294 +9
=========================================
+ Hits 296 305 +9
- Misses 3336 3527 +191 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slightly largeish breaking change, but only revolves around linting really.
If you are using the old husky integration, that used node/npm, it has now switched over to Husky.Net. This removes the need for both the npm husky module and lint-staged.
Note: Prettier in your package.json is still needed however.