BAP-22546: Fix application crash after update to symfony/property-acc…

…ess v6.4.6 (#38013)

- since symfony/property-access 6.4.6 the application crashed with a lot of exceptions like "Can't get a way to read the property ... in class ...", see symfony/symfony#54194

src/Oro/Bundle/ActionBundle/Form/Type/OperationType.php

@@ -14,6 +14,9 @@
 use Symfony\Component\Form\FormEvents;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
+/**
+ * The form type for action operations.
+ */
 class OperationType extends AbstractType
 {
     const NAME = 'oro_action_operation';
@@ -105,7 +108,7 @@ function (FormEvent $event) use ($options) {
                     $data = $event->getData();
 
                     foreach ($options['attribute_default_values'] as $attributeName => $value) {
-                        $data->$attributeName = $this->contextAccessor->getValue($data, $value);
+                        $data->set($attributeName, $this->contextAccessor->getValue($data, $value));
                     }
                 }
             );
@@ -145,8 +148,8 @@ protected function addAttributes(FormBuilderInterface $builder, array $options)
                 $attributeOptions = [];
             }
 
-            if (isset($actionData->$attributeName)) {
-                $attributeOptions['options']['data'] = $actionData->$attributeName;
+            if ($actionData->has($attributeName)) {
+                $attributeOptions['options']['data'] = $actionData->get($attributeName);
             }
 
             $attributeOptions = $this->prepareAttributeOptions($attribute, $attributeOptions, $options);

src/Oro/Bundle/ActionBundle/Tests/Unit/Model/ActionDataTest.php

@@ -31,15 +31,15 @@ public function testIssetGetSetUnset()
     {
         $data = new ActionData();
 
-        $this->assertFalse(isset($data->foo));
+        $this->assertTrue(isset($data->foo));
         $this->assertNull($data->foo);
 
         $data->foo = 'bar';
         $this->assertTrue(isset($data->foo));
         $this->assertEquals('bar', $data->foo);
 
         unset($data->foo);
-        $this->assertFalse(isset($data->foo));
+        $this->assertTrue(isset($data->foo));
         $this->assertNull($data->foo);
     }
 

src/Oro/Bundle/EntityExtendBundle/EntityExtend/AbstractAssociationEntityFieldExtension.php

@@ -205,6 +205,7 @@ public function call(EntityFieldProcessTransport $transport): void
      */
     public function isset(EntityFieldProcessTransport $transport): void
     {
+        $this->propertyExists($transport);
     }
 
     /**

src/Oro/Bundle/EntityExtendBundle/EntityExtend/AbstractEntityFieldExtension.php

@@ -66,6 +66,7 @@ protected function getCachedExtensionItem(
 
     public function isset(EntityFieldProcessTransport $transport): void
     {
+        $this->propertyExists($transport);
     }
 
     protected function getMethodsData(EntityFieldProcessTransport $transport): array

src/Oro/Bundle/LocaleBundle/EntityExtend/LocaleEntityFieldExtension.php

@@ -374,15 +374,6 @@ public function call(EntityFieldProcessTransport $transport): void
         }
     }
 
-    public function isset(EntityFieldProcessTransport $transport): void
-    {
-        $properties = $this->getProperties($transport);
-        if (array_key_exists($transport->getName(), $properties)) {
-            $transport->setResult(true);
-            $transport->setProcessed(true);
-        }
-    }
-
     public function propertyExists(EntityFieldProcessTransport $transport): void
     {
         $properties = $this->getProperties($transport);

src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/WorkflowDataTest.php

@@ -56,15 +56,15 @@ public function testHasGetSetRemove()
 
     public function testIssetGetSetUnset()
     {
-        $this->assertFalse(isset($this->data->foo));
+        $this->assertTrue(isset($this->data->foo));
         $this->assertNull($this->data->foo);
 
         $this->data->foo = 'bar';
         $this->assertTrue(isset($this->data->foo));
         $this->assertEquals('bar', $this->data->foo);
 
         unset($this->data->foo);
-        $this->assertFalse(isset($this->data->foo));
+        $this->assertTrue(isset($this->data->foo));
         $this->assertNull($this->data->foo);
     }
 

src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/WorkflowResultTest.php

@@ -40,15 +40,15 @@ public function testHasGetSetRemove()
 
     public function testIssetGetSetUnset()
     {
-        $this->assertFalse(isset($this->result->foo));
+        $this->assertTrue(isset($this->result->foo));
         $this->assertNull($this->result->foo);
 
         $this->result->foo = 'bar';
         $this->assertTrue(isset($this->result->foo));
         $this->assertEquals('bar', $this->result->foo);
 
         unset($this->result->foo);
-        $this->assertFalse(isset($this->result->foo));
+        $this->assertTrue(isset($this->result->foo));
         $this->assertNull($this->result->foo);
     }
 

src/Oro/Component/Action/Model/AbstractStorage.php

@@ -223,7 +223,7 @@ public function __unset($name)
      */
     public function __isset($name)
     {
-        return $this->has($name);
+        return true;
     }
 
     /**