[workspace] Upgrade mypy_internal to latest release v1.8.0 #20745
Conversation
mwoehlke-kitware
added
the
release notes: fix
mwoehlke-kitware
force-pushed
the
upgrade-mypy
branch
from
4390b90
to
e964ecd
Compare
mwoehlke-kitware
changed the title
|
FYI @mwoehlke-kitware you're probably as knowledgeable about mypy as I am at this point, so it's OK by me if you want to dig in and try to repair this one on your own. I'm hoping it's just a small tweak or two. |
Yes, I had the same thought. I probably won't be able to get to it today, however. Good news is it's also failing for me locally and doesn't seem to be a case of the infamous timeout. In any case, I think separating this so it isn't blocking the other updates was/is TRTTD. +@mwoehlke-kitware to fix. |
mwoehlke-kitware
force-pushed
the
upgrade-mypy
branch
from
e964ecd
to
8766635
Compare
|
FYI, the relevant upstream change is python/mypy#16608. |
jwnimmer-tri
added
the
status: single reviewer ok
There was a problem hiding this comment.
Looks good on paper. I'm going to do some local testing before we merge this.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee mwoehlke-kitware
a discussion (no related file):
Working
Confirm that pyi errors are still detected when the build/docs have bugs.
There was a problem hiding this comment.
Reviewable status: LGTM missing from assignee mwoehlke-kitware
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Working
Confirm that pyi errors are still detected when the build/docs have bugs.
Confirmed good.
I commented out our reject_double_colon.patch patch, so that the *.pyi files were broken. The unit test correctly reported on the broken files.
Toward #20723.
This change is