Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed modifiers of trait method when method does not exist in current class #1485

Merged
merged 1 commit into from
Feb 9, 2025
Merged

Fixed modifiers of trait method when method does not exist in current class #1485

merged 1 commit into from
Feb 9, 2025
+99 −13

Conversation

ondrejmirtes
Copy link
Contributor

@ondrejmirtes ondrejmirtes mentioned this pull request Feb 8, 2025
Closed
@Ocramius
Copy link
Member

Ocramius commented Feb 8, 2025

Gotta reset that "errors since traits or property accessors haven't been a nuisance" counter

@ondrejmirtes @kukulich
Fixed modifiers of trait method when method does not exist in current…

Verified

This commit was signed with the committer’s verified signature.
slawekjaranowski Slawomir Jaranowski
GPG key ID: 9EB80E92EB2135B1
Verified
Learn about vigilant mode
Loading
Loading status checks…
c3fa1cb 
… class
@kukulich kukulich force-pushed the trait-method-alias-test branch from 03269f2 to c3fa1cb Compare February 9, 2025 09:40
@kukulich kukulich added the bug label Feb 9, 2025
@kukulich kukulich changed the title Failing test - trait method alias Fixed modifiers of trait method when method does not exist in current class Feb 9, 2025
@kukulich kukulich marked this pull request as ready for review February 9, 2025 09:54
Ocramius
Ocramius approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kukulich!

@Ocramius Ocramius self-assigned this Feb 9, 2025
@Ocramius Ocramius added this to the 6.56.0 milestone Feb 9, 2025
@Ocramius Ocramius merged commit 87fc501 into Roave:6.56.x Feb 9, 2025
30 checks passed
@ondrejmirtes
Copy link
Contributor Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
6.56.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ondrejmirtes @Ocramius @kukulich