Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent extra log messages in stdout #199

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Mar 25, 2024

Description

GitLab CI still logs extra messages with log filtering. Disabling propagation to isolate the trestlbot logger similar to the compliance-trestle logger.

Add a fix in tests to ensure logs are still found using caplog during test time

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sorry, something went wrong.

GitLab CI still logs extra messages with the
log filtering. Adds this line to prevent this.

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 added the bug Something isn't working label Mar 25, 2024
@jpower432 jpower432 requested a review from beatrizmcouto March 25, 2024 23:01
@jpower432 jpower432 marked this pull request as ready for review March 25, 2024 23:01
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

The test_logger setup should not be packaged with the
trestlebot code

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432
Copy link
Member Author

Thanks for the review @beatrizmcouto. After a quick re-review, I realized that the configure_test_logger should be with the test code and not in log.py. cdb39ec moves it over.

@jpower432 jpower432 added this to the 0.8.1 milestone Mar 26, 2024
Safety checks should not fail PRs with no
dependency changes

Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
@jpower432 jpower432 merged commit 05b0c4c into main Mar 26, 2024
11 checks passed
@jpower432 jpower432 deleted the bug/duplicate-log-gitlab branch March 27, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants