Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed emulator download URL #343

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fixed emulator download URL #343

merged 1 commit into from
Jul 4, 2023

Conversation

olegdolgikh
Copy link
Contributor

Previous code worked in a wrong way.

  1. Getting the first char of a build number is mistake because now numbers start with 1, but whole number higher than the number which starts from 7.
  2. URL was incorrect for arm mac machines. It needed to add aarch64 suffix

@olegdolgikh
Fixed emulator download URL
d73b551 
Previous code worked in a wrong way. 
1. Getting the first char of a build number is mistake because now numbers start with 1, but whole number higher than the number which starts from 7.
2. URL was incorrect for arm mac machines. It needed to add `aarch64` suffix
@ychescale9 ychescale9 merged commit 2cfd145 into ReactiveCircus:main Jul 4, 2023
6 of 8 checks passed
@joshrlesch joshrlesch mentioned this pull request Dec 5, 2023
Closed
ychescale9 added a commit that referenced this pull request Dec 6, 2023
@ychescale9
Merge branch 'main' into release/v2
99a4aac 
* main:
  Prepare for release 2.29.0.
  SDK command-line tools 11.0. (#356)
  Update npm packages. (#355)
  Check in updated `*.js` file.
  Update test fixture dependencies. (#354)
  Upgrade to latest npm dependencies (#347)
  Fixed emulator download URL (#343)
  Update README.md (Who is using…) (#335)
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olegdolgikh @ychescale9