fix: update node contains conditional check on Tooltip component

[danielbarion]

closes #985

[gabrieljablonski]

I have no problem with doing this change but it feels unnecessary. mutation.removedNodes should never have a null node inside it, and if a node is not null, it will always have the contains() method defined.

Maybe in older browsers something weird might happen? Or maybe if the reference to the node becomes stale contains becomes null?

Again, we can do the change just in case, but if #985 wasn't just a suggestion, and @rolandpoulter actually ran into an error because of this, I'd love to see a reproducible example purely out of curiosity.

[danielbarion]

@gabrieljablonski I do agree with you, can you handle this PR and this issue, please?

[gabrieljablonski]

@danielbarion No problem. I'll just wait for a response from @rolandpoulter and take it from there.

[rolandpoulter]

@gabrieljablonski I can look into the reason why, but I did get an error after upgrading to the latest version. I patched it in my node_modules with the above change because I noticed in the code you are checking for node to be truthy before calling contains elsewhere. There might be something on my end with how I wrapped the tooltip that causes this issue but it will take some time to investigate and provide the exact reproduction.

[gabrieljablonski]

@gabrieljablonski I can look into the reason why, but I did get an error after upgrading to the latest version. I patched it in my node_modules with the above change because I noticed in the code you are checking for node to be truthy before calling contains elsewhere. There might be something on my end with how I wrapped the tooltip that causes this issue but it will take some time to investigate and provide the exact reproduction.

@rolandpoulter No worries, just wanted to make sure this was what solved your problem. We'll merge this change and release a new version soon.

Thanks for reporting it!