Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tooltip placement using classes #970

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

gabrieljablonski
Copy link
Member

Closes #969

Beta release for testing: yarn add react-tooltip@5.9.1-beta.0

Verified

This commit was signed with the committer’s verified signature. The key has expired.
infinisil Silvan Mosberger

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -27,7 +27,7 @@ exports[`tooltip props clickable tooltip 1`] = `
Lorem Ipsum
</span>
<div
class="react-tooltip undefined"
class="react-tooltip react-tooltip__place-top undefined"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using the clickable prop, we get an undefined classname when testing. this doesn't happen outside of testing.

any ideas @danielbarion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's weird, I'll take a look when I have some available time, but this is not a blocker for this PR as this is an extra-class

@gabrieljablonski gabrieljablonski merged commit f4d9747 into master Mar 6, 2023
@gabrieljablonski gabrieljablonski deleted the feat/tooltip-placement branch March 6, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT REQ]: Indicate the actual place where tooltip is rendered in some way
2 participants