Hide tooltip when anchor element is removed from the DOM #926
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieljablonski
force-pushed
the
fix/remove-anchor-hide-tooltip
branch
from
5e206f1 to
1348916
Compare
gabrieljablonski
force-pushed
the
fix/remove-anchor-hide-tooltip
branch
from
1348916 to
4d894de
Compare
danielbarion
approved these changes
Jan 30, 2023
|
I don't know yet if there is a better way to do this, but the code looks good to me, feel free to merge when you want :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #924.
The
MutationObserverAPI is supposed to be super optimized, so this should scale fine, but I still worry if there isn't a more efficient way to do this.