Skip to content

Adding middlewares #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

alburkerk
Copy link
Contributor

@alburkerk alburkerk commented Jan 19, 2023

Following this this discussion : #909

I created a draft PR to enable configuration.

  • Middleware are now fully customisable in Tooltip config (no data attribute config for now)
  • Relevant floating-ui middlewares are exported from the barrel file to prevent user to create a useless peer dependancy
  • Exemple in app.tsx demonstrating a use case

Capture d’écran 2023-01-19 à 12 34 16

image

@gabrieljablonski
Copy link
Member

Thanks for the contribution. Everything seems fine at first glance.

I'll do some testing later and also update the docs.

@gabrieljablonski gabrieljablonski merged commit d4da340 into ReactTooltip:master Jan 23, 2023
@MagicFame
Copy link

Very great pull request ! Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants