Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changeable role attribute #1124

Merged
merged 4 commits into from Nov 21, 2023
Merged

Changeable role attribute #1124

merged 4 commits into from Nov 21, 2023

Conversation

mailinhdang
Copy link

Closes #1123.

gabrieljablonski
gabrieljablonski requested changes Nov 21, 2023
View reviewed changes
Copy link
Member

@gabrieljablonski gabrieljablonski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the generic AriaRole type should cover all other possible cases, not only the dialog alternative.

docs/docs/options.mdx Outdated Show resolved Hide resolved
src/components/Tooltip/TooltipTypes.d.ts Outdated Show resolved Hide resolved
src/components/TooltipController/TooltipControllerTypes.d.ts Outdated Show resolved Hide resolved
@mailinhdang
Copy link
Author

I committed a change with the generic type AriaRole :)
Was thinking about using it before but thought it would be too generic and open for misuse but it's certainly more flexible.

@danielbarion
Copy link
Member

Looks great!

Thanks for the contribution :)

@gabrieljablonski gabrieljablonski merged commit 708bfa6 into ReactTooltip:master Nov 21, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbarion danielbarion danielbarion approved these changes

@gabrieljablonski gabrieljablonski gabrieljablonski approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT REQ] Changeable role attribute (v5)
3 participants
@mailinhdang @danielbarion @gabrieljablonski