Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeOnScroll improvements #1045

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Conversation

gabrieljablonski
Copy link
Member

@gabrieljablonski gabrieljablonski commented Jun 21, 2023

Closes #1044.

  • Ignore delayHide and close immediately
  • Add listeners to tooltip and anchor parents

Beta version react-tooltip@5.15.0-beta.1045.0

@gabrieljablonski
Copy link
Member Author

@danielbarion if you can, please take like 30s to think about the topic order on the troubleshooting section. The current order is what I guess would be most likely of happening, to least likely.

export * from 'react-tooltip'
export { Tooltip } from 'react-tooltip'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrieljablonski gabrieljablonski merged commit d744bc8 into master Jun 22, 2023
5 checks passed
@gabrieljablonski gabrieljablonski deleted the fix/close-on-scroll-listeners branch June 22, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tooltip position not updated on scroll
2 participants