Skip to content

closeOnScroll and closeOnResize props #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

gabrieljablonski
Copy link
Member

Closes #1031.

Originally I though of leaving these behaviors as default, but it almost feels like a breaking change.

We can revisit this in the future to decide if it is a good idea to leave them on by default, and having the disableCloseOn... props instead.

Verified

This commit was signed with the committer’s verified signature.
stevenharman Steven Harman
@gabrieljablonski
Copy link
Member Author

As a side note, we should mark down the closeOn... props for refactoring in a future major version bump.

Everywhere else we already use hide/hidden instead of close, but I decided to use close here since closeOnEsc already exists, which should've been named hideOnEsc originally.

Verified

This commit was signed with the committer’s verified signature.
stevenharman Steven Harman
@gabrieljablonski gabrieljablonski merged commit d5b462b into master Jun 14, 2023
@gabrieljablonski gabrieljablonski deleted the feat/close-on-scroll-resize branch June 14, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT REQ] Hide on scroll/resize
2 participants