feat: log invalid CSS selector with tooltip-id #1026
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data-tooltip-id may be invalid too, so we can log that value for better troubleshooting.
danielbarion
approved these changes
May 19, 2023
|
@dtamai thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is this warning for when the CSS selector is invalid in TooltipController.
It was useful for me when I troubleshooting an issue with a tooltip but it would print only
[react-tooltip] "undefined" is not a valid CSS selector, but the issue was that the CSS selector contained a\r\nthat made it invalid, not that it was undefined.The warning is not printing the invalid selector when it is using the
data-tooltip-idattribute. This PR proposes to print theselectorvariable that covers both selectors - anchor and id.This produces the warning below (there is a line break in the selector):
🎉 And thanks for maintaining this package! The recent addition of the try/catch block that prints the warning means that only the tooltip breaks, not the whole page.