Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the build to auto inject css into the page #1014

Merged
merged 6 commits into from
May 16, 2023

Conversation

danielbarion
Copy link
Member

@danielbarion danielbarion commented Apr 14, 2023

  • Keep the styles being generated (react-tooltip.css) - with this, we can prevent this from being a breaking change and release a feature version.
  • Update build to auto-inject the CSS into the page
  • Update docs about the deprecation of the CSS import

https://codesandbox.io/s/tender-lucy-rq1tsv?file=/src/App.js

image

Extra: fix Next.js 13 App project cannot use client side component on server side components by adding use client on react-tooltip. Tested with development and production build of Next.js

On a fresh Next.js 13 App project:
image

Sorry, something went wrong.

@danielbarion
Copy link
Member Author

danielbarion commented Apr 14, 2023

Beta version released:

yarn add react-tooltip@5.12.0-beta.1014.3

or

npm install react-tooltip@5.12.0-beta.1014.3

@github-actions
Copy link

This pull request is stale because it has not seen activity in 30 days. Remove the stale label or comment within 14 days, or it will be closed.

@github-actions github-actions bot added the Stale This has not seen activity in quite some time label May 15, 2023
@danielbarion danielbarion removed the Stale This has not seen activity in quite some time label May 15, 2023
@danielbarion danielbarion force-pushed the feat/auto-inject-css branch from ed6bf67 to a0e1c20 Compare May 16, 2023 16:03
@danielbarion danielbarion marked this pull request as ready for review May 16, 2023 16:31
@danielbarion danielbarion merged commit cdc1a74 into master May 16, 2023
@danielbarion danielbarion deleted the feat/auto-inject-css branch May 16, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants