Fix build on non-MSVC compilers for Windows platforms #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LostRuins was having this issue using mingw to compile rwkv.cpp.
The issue was that mingw doesn't report MSVC defines & doesn't even declare the fstat family of functions unless
sys/stat.his included.So I moved that include out of the Linux specific section and also tried to detect Windows platforms in general rather than only MSVC.
Maybe this would also fix using MSVC on non-windows platforms, idk. (Does MSVC even exist on other platforms?)