Expose n_vocab, n_embed, n_layer to the Python interface #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saharNooby
approved these changes
Jul 18, 2023
|
CC @LoganDark |
|
Logan isn't here right now so can't actually offer his opinion, but it looks fine to me! |
|
Just was tagging you since you are working on Python API rewrite (AFAIK) :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch exposes the rwkv_get_n_vocab, rwkv_get_n_embed, rwkv_get_n_layer functions to the Python interface through the n_vocab, n_embed, n_layer properties of the RWKVSharedLibrary class.