Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tox config #1691

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented Jan 24, 2022

  • Removed some redundant options.
  • Created a covreport environment for reporting coverage for all
    environments.
  • Make it possible to run a custom command instead of pytest.
  • Make it possible to run an extra command
  • Make it possible to change the mypy command
  • Use extras instead of using requirements files.
  • Improve rebuild speed of docs environment by not using an ephemeral doctree dir.

Also:

  • Update setup.py
    • Remove berkleydb and networkx from tests_require and tests extra
      group as they are not always needed for tests.
    • Added separate extra groups for berkleydb and networkx
    • Added a dev extras group with dev tools.
  • Update github actions
    • Use tox to run tests.
    • Run flake8 only once instead of for every OS and python version.
    • Change docs job to rather be more generic for potential future tox
      environments.

NOTE: Split off from #1672

@aucampia aucampia force-pushed the iwana-20220124T2147-better_tox branch 2 times, most recently from 25e96c7 to d9296db Compare January 24, 2022 22:04
@aucampia aucampia marked this pull request as ready for review January 24, 2022 22:07
@aucampia aucampia force-pushed the iwana-20220124T2147-better_tox branch 2 times, most recently from b58ef24 to 471dbcf Compare January 29, 2022 23:52
@aucampia aucampia force-pushed the iwana-20220124T2147-better_tox branch 5 times, most recently from c8f1bfa to e90accf Compare February 26, 2022 12:33
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label Feb 26, 2022
@aucampia aucampia force-pushed the iwana-20220124T2147-better_tox branch from e90accf to eb78c98 Compare March 15, 2022 21:16
- Removed some redundant options.
- Created a covreport environment for reporting coverage for all
environments.
- Make it possible to run a custom command instead of pytest.
- Make it possible to run an extra command
- Make it possible to change the mypy command
- Use extras instead of using requirements files.
- Improve rebuild speed of docs environment by not using an ephemeral doctree dir.

Also:

- Update setup.py
  - Remove berkleydb and networkx from tests_require and tests extra
    group as they are not always needed for tests.
  - Added separate extra groups for berkleydb and networkx
  - Added a dev extras group with dev tools.
- Update github actions
  - Use tox to run tests.
  - Run flake8 only once instead of for every OS and python version.
  - Change docs job to rather be more generic for potential future tox
    environments.
@aucampia aucampia force-pushed the iwana-20220124T2147-better_tox branch from eb78c98 to 1696972 Compare March 16, 2022 21:42
Copy link
Member

@nicholascar nicholascar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I matched the black version to PR #1763 but otherwise unchanged

Copy link
Member

@white-gecko white-gecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nicholascar nicholascar merged commit 6ab7bb2 into RDFLib:master Mar 17, 2022
@aucampia aucampia deleted the iwana-20220124T2147-better_tox branch April 9, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted This indicates that the PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants