refactor: remove references to currentScript
#6559
Merged
+230
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for qwik-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
commit: @builder.io/qwik
@builder.io/qwik-city
eslint-plugin-qwik
create-qwik
|
mhevery
force-pushed
the
build/feat-containerAttributes
branch
from
8f33ce0 to
8e28b82
Compare
Deploying qwik-docs with
|
| Latest commit: |
dd0fbda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50e947c1.qwik-8nx.pages.dev |
| Branch Preview URL: | https://build-feat-containerattribut.qwik-8nx.pages.dev |
Deploying qwik-docs with
|
| Latest commit: |
8e28b82
|
| Status: | ⚡️ Build in progress... |
mhevery
force-pushed
the
build/feat-containerAttributes
branch
from
8e28b82 to
dfed462
Compare
mhevery
force-pushed
the
build/feat-containerAttributes
branch
from
dfed462 to
bb934d3
Compare
gioboa
previously approved these changes
Jun 17, 2024
mhevery
force-pushed
the
build/feat-containerAttributes
branch
from
91f4182 to
d22354a
Compare
`currentScript` is not available in shadow dom. For this reason we can't use it. This change removes all references to `currentScript` The biggest change is that the `qFuncs` are no longer written to the container element but rather to the document. Because there is only one document the `qFuncs` property now includes the `container` `q:manifest-hash` to distinguish between different containers.
mhevery
force-pushed
the
build/feat-containerAttributes
branch
from
d22354a to
dd0fbda
Compare
genki
pushed a commit
to genki/qwik
that referenced
this pull request
Jun 28, 2024
* refactor: remove references to `currentScript` `currentScript` is not available in shadow dom. For this reason we can't use it. This change removes all references to `currentScript` The biggest change is that the `qFuncs` are no longer written to the container element but rather to the document. Because there is only one document the `qFuncs` property now includes the `container` `q:manifest-hash` to distinguish between different containers. * fixup! refactor: remove references to `currentScript`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentScriptis not available in shadow dom. For this reason we can't use it. This change removes all references tocurrentScriptThe biggest change is that the
qFuncsare no longer written to the container element but rather to the document. Because there is only one document theqFuncsproperty now includes thecontainerq:manifest-hashto distinguish between different containers.