Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove the custom portals section #6525

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

thejackshelton
Copy link
Member

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@thejackshelton thejackshelton requested review from a team as code owners June 12, 2024 15:15
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit f5371b0
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/6669bb800a375f00089be5f3
😎 Deploy Preview https://deploy-preview-6525--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thejackshelton thejackshelton changed the title Remove the custom portals section docs: remove the custom portals section Jun 12, 2024
Copy link

pkg-pr-new bot commented Jun 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@builder.io/qwik (f5371b0)

npm i https://pkg.pr.new/@builder.io/qwik@6525

@builder.io/qwik-city (f5371b0)

npm i https://pkg.pr.new/@builder.io/qwik-city@6525

eslint-plugin-qwik (f5371b0)

npm i https://pkg.pr.new/eslint-plugin-qwik@6525

create-qwik (f5371b0)

npm i https://pkg.pr.new/create-qwik@6525

Copy link

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f5371b0
Status: ✅  Deploy successful!
Preview URL: https://472c4d52.qwik-8nx.pages.dev
Branch Preview URL: https://thejackshelton-patch-2.qwik-8nx.pages.dev

View logs

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @thejackshelton thanks

@gioboa gioboa merged commit 96d8045 into main Jun 12, 2024
29 of 30 checks passed
@gioboa gioboa deleted the thejackshelton-patch-2 branch June 12, 2024 21:40
genki pushed a commit to genki/qwik that referenced this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants