Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prefetch): configure scope and give better errors #6366

Merged
merged 10 commits into from
May 23, 2024

Conversation

PatrickJS
Copy link
Member

fix configuring scope value.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

netlify bot commented May 23, 2024

Deploy Preview for qwik-insights ready!

Name Link
🔨 Latest commit 78546da
🔍 Latest deploy log https://app.netlify.com/sites/qwik-insights/deploys/664ecc252adf930007d7645b
😎 Deploy Preview https://deploy-preview-6366--qwik-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented May 23, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 78546da
Status: ✅  Deploy successful!
Preview URL: https://2cc6e5c7.qwik-8nx.pages.dev
Branch Preview URL: https://fix-prefetch-service-worker.qwik-8nx.pages.dev

View logs

Copy link
Member

@thejackshelton thejackshelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌 . Thank you for adding tests

@PatrickJS PatrickJS merged commit d4ae6ab into main May 23, 2024
28 checks passed
@PatrickJS PatrickJS deleted the fix-prefetch-service-worker-with-scope branch May 23, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants