Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up some control flow and optimized some parts. #1241

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

Larmbs
Copy link
Contributor

@Larmbs Larmbs commented Jul 2, 2024

This is my second time doing this, forgot to format final result.

I just made some changes to control flow to optimize some parts. The code does the exact same thing but is just shorter and more readable.

Larmbs added 2 commits July 1, 2024 18:33

Verified

This commit was signed with the committer’s verified signature.
vEnhance Evan Chen

Verified

This commit was signed with the committer’s verified signature.
vEnhance Evan Chen
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9767504553

Details

  • 31 of 32 (96.88%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.803%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/min_scored.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 9763575829: 0.02%
Covered Lines: 18035
Relevant Lines: 18825

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I am surprised Clippy didn’t find some of these. Some of them are more trivial than others so I still need to re-review some of the if -> match conditions. Test cases should catch regressions, but just to be safe

@Larmbs
Copy link
Contributor Author

Larmbs commented Jul 4, 2024

Yeah, I believe the control flow should be identical but it's best not to risk it.

Verified

This commit was signed with the committer’s verified signature.
vEnhance Evan Chen
@IvanIsCoding
Copy link
Collaborator

Code coverage is 100% and I checked the matches, I think it is good to go

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Jul 4, 2024
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9787794796

Details

  • 31 of 32 (96.88%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 95.803%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/min_scored.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 9763575829: 0.02%
Covered Lines: 18035
Relevant Lines: 18825

💛 - Coveralls

@IvanIsCoding IvanIsCoding merged commit 553bff1 into Qiskit:main Jul 4, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants