Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement two_qubit_decompose.num_basis_gates in rust #11019

Merged
merged 40 commits into from
Jan 29, 2024
Merged

Reimplement two_qubit_decompose.num_basis_gates in rust #11019

merged 40 commits into from
Jan 29, 2024

Commits on Oct 13, 2023

  1. Use newer rust

    @jlapeyre
    jlapeyre committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    33cd338 View commit details
    Browse the repository at this point in the history

  2. Adding weyl chamber code in rust

    @jlapeyre
    jlapeyre committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    05e5067 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Finish num_basis_gates in rust, but calculated values wrong

    @jlapeyre
    jlapeyre committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    861c796 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Fix bugs in weyl_coordinates

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b6b0a20 View commit details
    Browse the repository at this point in the history

  2. Upgrade faer from 0.12 to 0.13 

    * This will allow copyless convert of numpy complex matrix to faer
* abs2 disappeared probably an error, so we work around here.
    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    fa30020 View commit details
    Browse the repository at this point in the history

  3. Use copyless conversion of complex matrix from numpy to faer

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ca33a59 View commit details
    Browse the repository at this point in the history

  4. Fix thinko bugs so that existing tests pass

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ee70810 View commit details
    Browse the repository at this point in the history

  5. Add comment

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    099e394 View commit details
    Browse the repository at this point in the history

  6. Remove allocation

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    462b849 View commit details
    Browse the repository at this point in the history

  7. Replace loop with iterator

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4b506f9 View commit details
    Browse the repository at this point in the history

  8. Silence clippy complaints

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    cd81326 View commit details
    Browse the repository at this point in the history

  9. refactor

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    a3ab146 View commit details
    Browse the repository at this point in the history

  10. Run rustfmt

    @jlapeyre
    jlapeyre committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ca07f86 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Slight refactor and format

    @jlapeyre
    jlapeyre committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    df6758d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into use-faer-crate

    @jlapeyre
    jlapeyre committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1768498 View commit details
    Browse the repository at this point in the history

  3. Reorganize new code in crate accelerate 

    * Moved `eigenvalues` into module `utils`.
* Access num_basis_gates via module two_qubit_decompose
    @jlapeyre
    jlapeyre committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c10ba5b View commit details
    Browse the repository at this point in the history

  4. Remove some allocations

    @jlapeyre
    jlapeyre committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0f7b253 View commit details
    Browse the repository at this point in the history

  5. Run rustfmt

    @jlapeyre
    jlapeyre committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e850342 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Raise faer version to 0.13.5, lower rustc to 1.67.0 

    faer 0.13.5 introduces a specific MSRV
    @jlapeyre
    jlapeyre committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e61bb4d View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Fix some conflicts with main branch

    @jlapeyre
    jlapeyre committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1864845 View commit details
    Browse the repository at this point in the history

  2. Fix more conflicts

    @jlapeyre
    jlapeyre committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5863145 View commit details
    Browse the repository at this point in the history

  3. More conflicts

    @jlapeyre
    jlapeyre committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    2498402 View commit details
    Browse the repository at this point in the history

  4. More conflicts

    @jlapeyre
    jlapeyre committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    9645e85 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into use-faer-crate

    @jlapeyre
    jlapeyre committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5de5f58 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Update crates/accelerate/src/two_qubit_decompose.rs 

    Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @jlapeyre @mtreinish
    jlapeyre and mtreinish committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    fd864e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Apply suggestions from code review 

    Apply several suggested edits made in review

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @jlapeyre @mtreinish
    jlapeyre and mtreinish committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    048d125 View commit details
    Browse the repository at this point in the history

  2. Increase faer version and remove some cruft 

    * We introduced to_num_complex, but this required upgrading faer. We chose 0.15
* Upgrade our code, in turn, for the upgrade to faer 0.15
* Remove a function exported via pyo3 that was only used for testing
* Remove `def old_num_basis_gate`
    @jlapeyre
    jlapeyre committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    96a3f80 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Make __num_basis_gates more idiomatic

    @jlapeyre
    jlapeyre committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    fecdd90 View commit details
    Browse the repository at this point in the history

  2. Explain use of min_by when max_by is expected

    @jlapeyre
    jlapeyre committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8263b0b View commit details
    Browse the repository at this point in the history

  3. Replace myabs2 with faer_abs2 

    We recently increased the version of the faer dependency.
The newer version has an abs2 in the api named `faer_abs2`.

So we can delete `myabs2`.
    @jlapeyre
    jlapeyre committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8ab3f37 View commit details
    Browse the repository at this point in the history

  4. Use alternative mod implementation following review requests

    @jlapeyre
    jlapeyre committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    2c79c61 View commit details
    Browse the repository at this point in the history

  5. Make pyo3 function eigenvalues return ndarray rather than list 

    Following review suggestion.
    @jlapeyre
    jlapeyre committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    7b9266b View commit details
    Browse the repository at this point in the history

  6. Bump faer version to latest 0.16 

    This was previously at 0.15 for accidental reasons.
    @jlapeyre
    jlapeyre committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    33d3806 View commit details
    Browse the repository at this point in the history

  7. Use rem_euclid for remainder

    @jlapeyre
    jlapeyre committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    edd963d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'main' into use-faer-merge-in-main

    @jlapeyre
    jlapeyre committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3945018 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Fix black complaint

    @jlapeyre
    jlapeyre committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    c81b169 View commit details
    Browse the repository at this point in the history

  2. Fix pylint complaints

    @jlapeyre
    jlapeyre committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    612bc88 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
    @jlapeyre @mtreinish
    jlapeyre and mtreinish committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e3ff78c View commit details
    Browse the repository at this point in the history

  4. Remove nalgebra feature from faer

    @mtreinish
    mtreinish committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ac305b1 View commit details
    Browse the repository at this point in the history

  5. Use constants for fractions of pi

    @mtreinish
    mtreinish committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e2f4ccb View commit details
    Browse the repository at this point in the history