Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx version to less than 7.2 #10655

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented Aug 17, 2023

Summary

The recent Sphinx 7.2 release is causing errors during docs jobs around the furo style sheet. There seems to be a compatibility issue between furo, qiskit_sphinx_theme, and this new Sphinx release. While the issue is getting resolved this commit pins the sphinx version we use in CI and for local docs builds to avoid the new release.

Details and comments

See sphinx-doc/sphinx#11608 for details

The recent Sphinx 7.2 release is causing errors during docs jobs around
the furo style sheet. There seems to be a compatibility issue between
furo, qiskit_sphinx_theme, and this new Sphinx release. While the issue
is getting resolved this commit pins the sphinx version we use in CI and
for local docs builds to avoid the new release.
@mtreinish mtreinish requested a review from a team as a code owner August 17, 2023 13:02
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish added type: qa Issues and PRs that relate to testing and code quality stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Aug 17, 2023
@mtreinish mtreinish added this to the 0.25.1 milestone Aug 17, 2023
@1ucian0 1ucian0 enabled auto-merge August 17, 2023 13:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5891278481

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 87.27%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 90.89%
Totals Coverage Status
Change from base Build 5883117042: 0.01%
Covered Lines: 74347
Relevant Lines: 85192

💛 - Coveralls

@1ucian0 1ucian0 added this pull request to the merge queue Aug 17, 2023
@mtreinish mtreinish removed this pull request from the merge queue due to a manual request Aug 17, 2023
@mtreinish mtreinish merged commit 998ce07 into Qiskit:main Aug 17, 2023
14 checks passed
@mtreinish mtreinish deleted the pin-sphinx branch August 17, 2023 14:14
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
The recent Sphinx 7.2 release is causing errors during docs jobs around
the furo style sheet. There seems to be a compatibility issue between
furo, qiskit_sphinx_theme, and this new Sphinx release. While the issue
is getting resolved this commit pins the sphinx version we use in CI and
for local docs builds to avoid the new release.

(cherry picked from commit 998ce07)
mtreinish added a commit that referenced this pull request Aug 17, 2023
The recent Sphinx 7.2 release is causing errors during docs jobs around
the furo style sheet. There seems to be a compatibility issue between
furo, qiskit_sphinx_theme, and this new Sphinx release. While the issue
is getting resolved this commit pins the sphinx version we use in CI and
for local docs builds to avoid the new release.

(cherry picked from commit 998ce07)

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants