Lex minus followed immediately by numeric literal as a single token #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, a `-` preceeding a numeric literal was always lexed as a token apart. Now lex the minus and the numeric literal as a single token. But only if there is no intervening whitespace. For example `-1.23` is a single token. But `- 1.123` is three tokens (including a token for the whitespace).
jlapeyre
force-pushed
the
minus-float-literal
branch
from
37d6c97
to
45c8fd6
Compare
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, a
-preceeding a numeric literal was always lexed as a token apart.Now lex the minus and the numeric literal as a single token. But only if there is no intervening whitespace. For example
-1.23is a single token. But- 1.123is three tokens (including a token for the whitespace).panicor incorrect parsing #81and
Qiskit/qiskit#11584 (comment)