Refactor abbr escaping #1449
Merged
Refactor abbr escaping #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A alternate fix to Python-Markdown#1444. This does not omit the use of carrots in abbreviations. It still omits backslashs, however. I played around with backslashes and it just doesn't make sense to support them as they have special meaning in the Markdown, not because of their use in regular expressions.
oprypin
reviewed
Mar 8, 2024
| @@ -15,7 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Include `scripts/*.py` in the generated source tarballs (#1430). | |||
| * Ensure lines after heading in loose list are properly detabbed (#1443). | |||
| * Give smarty tree processor higher priority than toc (#1440). | |||
| * Explicitly omit carrot (`^`) and backslash (`\`) from abbreviations (#1444). | |||
| * Permit carrots (`^`) and square brackets (`]`) but explicitly exclude | |||
There was a problem hiding this comment.
This should be "caret", not "carrot" 🤔
There was a problem hiding this comment.
@waylan I think you missed this comment before merge ⬆️ .
There was a problem hiding this comment.
Yeah, I didn't see it until after the merge. We'll fix it next time we edit the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A alternate fix to #1444. This does not omit the use of carrots in abbreviations. It still omits backslashs, however. I played around with backslashes and it just doesn't make sense to support them as they have special meaning in the Markdown, not because of their use in regular expressions.