-
-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Document Option.channel_types and properly support further channel types #1883
fix: Document Option.channel_types and properly support further channel types #1883
Conversation
So some clarification
Thus changes:
Though I can see these some of this being questionable, so do give your thoughts. |
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1883 +/- ##
==========================================
- Coverage 33.27% 33.26% -0.01%
==========================================
Files 96 96
Lines 18695 18696 +1
==========================================
Hits 6220 6220
- Misses 12475 12476 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: BobDotCom <71356958+BobDotCom@users.noreply.github.com> Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Signed-off-by: UK <41271523+NeloBlivion@users.noreply.github.com>
Summary
discord.Option.channel_types
input_type
to acceptdiscord.ForumChannel
anddiscord.DMChannel
.Ref. discord.ForumChannel Bug #1882
channel_types
now overrides theinput_type
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.